public icon indicating copy to clipboard operation
public copied to clipboard

Update telemetry-atomic description

Open romeyod opened this issue 1 year ago • 9 comments

  • (M) aft/openconfig-aft-common.yang

Change Scope

  • Update telemetry-atomic description to clarify the list container behavior.
  • This change is backwards compatible.

romeyod avatar Jan 02 '25 17:01 romeyod

/gcbrun

dplore avatar Jan 03 '25 00:01 dplore

No major YANG version changes in commit 9e06e9f970b79deb796fce9ac2227d459c9ae486

OpenConfigBot avatar Jan 03 '25 00:01 OpenConfigBot

/gcbrun

dplore avatar Mar 07 '25 23:03 dplore

/gcbrun

dplore avatar Mar 07 '25 23:03 dplore

Added to OC operator review for March 11, 2025

dplore avatar Mar 07 '25 23:03 dplore

I'm finding the text in this proposed clarification a bit confusing. The first change actually removes a reference to lists and instead says leaf-list. Was that really intended? I'm pretty sure the intention is for this to apply to containers and lists. The term "list of containers" is also somewhat confusing. I believe this clarification is trying to say that when a single list entry changes, only that specific list entry (and all its descendants) is updated (not all entries in the list).

jsterne avatar Mar 10 '25 16:03 jsterne

Perhaps the description could be clarified more like @jsterne recommends:

"When a single list entry changes, only that specific list entry and all its descendants are updated, not all entries in the list."

Is there some reason to exclude list? That part seemed clear to me already.

dplore avatar Apr 01 '25 23:04 dplore

Perhaps the description could be clarified more like @jsterne recommends:

"When a single list entry changes, only that specific list entry and all its descendants are updated, not all entries in the list."

Is there some reason to exclude list? That part seemed clear to me already.

I have incorporated the feedback. Thanks @jsterne and @dplore Let me know what you think of the latest diffs.

romeyod avatar Apr 01 '25 23:04 romeyod

That looks more clear to me now - thanks.

jsterne avatar Apr 02 '25 12:04 jsterne