public icon indicating copy to clipboard operation
public copied to clipboard

New set-as-path BGP action, and support last AS for for setting AS path.

Open xuqma opened this issue 1 year ago • 11 comments

Change Scope

  • Add set-as-path BGP action to replacing the entire AS path attribute with the following new path:
    • /routing-policy/policy-definitions/policy-definition/statements/statement/actions/bgp-actions/set-as-path (a list of ASNs or last-as)
  • Add oc-bgp-pol:bgp-as-mode-type to specify last AS in set-as-path.
    • This type is only used for BGP policies, so I decided to put it in oc-bgp-pol instead of oc-bgp-types.
  • This change is backwards compatible.

New paths after the model update:

To be updated.

Platform Implementations

xuqma avatar Jul 15 '24 05:07 xuqma

/gcbrun

dplore avatar Jul 16 '24 01:07 dplore

No major YANG version changes in commit fd28c0449ab1a7e21dd1564be7e3d3c76d3c8dd7

OpenConfigBot avatar Jul 16 '24 01:07 OpenConfigBot

Removed the extra comma and rebased against master.

xuqma avatar Jul 16 '24 20:07 xuqma

/gcbrun

dplore avatar Aug 07 '24 00:08 dplore

/gcbrun

dplore avatar Nov 12 '24 06:11 dplore

/gcbrun

dplore avatar Jan 03 '25 00:01 dplore

/gcbrun

dplore avatar Jan 03 '25 01:01 dplore

/gcbrun

dplore avatar Jan 03 '25 01:01 dplore

LGTM, moving to last call for Jan 16, 2025

dplore avatar Jan 03 '25 01:01 dplore

Thanks Darren! I have fixed the revisions based on the previous check result.

xuqma avatar Jan 03 '25 23:01 xuqma

Hi @xuqma , still waiting on your comment or changes. Probably this should just be changed to use the defined-sets for as-path.

ie: /routing-policy/defined-sets/bgp-defined-sets/as-path-sets/as-path-set/config/as-path-set-member

dplore avatar Feb 11 '25 17:02 dplore