public icon indicating copy to clipboard operation
public copied to clipboard

Clarification to usage of container `.../use-multiple-paths/*bgp/link-bandwidth-ext-community/`

Open rszarecki opened this issue 1 year ago • 5 comments

Change Scope

Clarification to usage of container .../use-multiple-paths/ebgp/link-bandwidth-ext-community/

rszarecki avatar Jun 25 '24 16:06 rszarecki

/gcbrun

wenovus avatar Jun 25 '24 21:06 wenovus

No major YANG version changes in commit ad4daf28ee49959145c94080f288d839e7667ca0

OpenConfigBot avatar Jun 25 '24 21:06 OpenConfigBot

/gcbrun

wenovus avatar Jun 28 '24 19:06 wenovus

/gcbrun

dplore avatar Oct 17 '24 00:10 dplore

Thanks for the contribution! LGTM, except there is a version conflict to be fixed.

  oc-ext:openconfig-version "9.7.2";

  revision "2024-07-25" {
    description
      "Clarification to usage of link-bandwidth-ext-community
      container under BGP use-multiple-paths`.";
          reference "9.7.2";
=======
  oc-ext:openconfig-version "9.8.0";

  revision "2024-09-06" {
    description
      "Restore NONE enum value for community-type.";
    reference "9.8.0";
>>>>>>> master
  }

dplore avatar Oct 17 '24 00:10 dplore

Overall LGTM from an Arista EOS perspective. The only thing I noticed is that this documentation change is using the phrasing "Usage of DMZ Link-Bandwidth extended community" which I found surprising. It makes it seem like this is a second special kind of link bandwidth extended community.

AFAIK, the "DMZ" link bandwidth terminology comes from the second link bandwidth RFC draft related to regenerating an aggregate: https://datatracker.ietf.org/doc/draft-ietf-bess-ebgp-dmz/. The main link bandwidth RFC draft which introduces the behavior described in this change makes no reference to "DMZ": https://datatracker.ietf.org/doc/draft-ietf-idr-link-bandwidth/

keon-arista avatar Mar 01 '25 00:03 keon-arista

Overall LGTM from an Arista EOS perspective. The only thing I noticed is that this documentation change is using the phrasing "Usage of DMZ Link-Bandwidth extended community" which I found surprising. It makes it seem like this is a second special kind of link bandwidth extended community.

AFAIK, the "DMZ" link bandwidth terminology comes from the second link bandwidth RFC draft related to regenerating an aggregate: https://datatracker.ietf.org/doc/draft-ietf-bess-ebgp-dmz/. The main link bandwidth RFC draft which introduces the behavior described in this change makes no reference to "DMZ": https://datatracker.ietf.org/doc/draft-ietf-idr-link-bandwidth/

Agree. removed "DMZ "

rszarecki avatar Apr 18 '25 16:04 rszarecki

/gcbrun

dplore avatar Apr 22 '25 16:04 dplore

Reviewed in Apr 22, 2025 OC Operators meeting without objection. Set last call to May 6, 2025

dplore avatar Apr 22 '25 16:04 dplore

/gcbrun

dplore avatar Apr 22 '25 20:04 dplore

/gcbrun

rszarecki avatar Apr 24 '25 05:04 rszarecki

/gcbrun

xw-g avatar Apr 24 '25 17:04 xw-g

/gcbrun

dplore avatar May 06 '25 16:05 dplore

@rszarecki due to other PR's merging in the versions will need to be updated to resolve the conflicts here.

dplore avatar May 06 '25 18:05 dplore

@rszarecki due to other PR's merging in the versions will need to be updated to resolve the conflicts here.

resolved

rszarecki avatar May 07 '25 15:05 rszarecki

/gcbrun

dplore avatar May 07 '25 17:05 dplore

/gcbrun

dplore avatar May 08 '25 18:05 dplore