public icon indicating copy to clipboard operation
public copied to clipboard

Add support for vni-peer-group container

Open mikewiebe opened this issue 2 years ago • 14 comments

Change Scope

The changes introduce operational state properties only.

  • Deprecate two properties control-plane-vnis and router-mac
    • This means the properties will be supported but deprecated and removed in a future OC model release
  • Add the new container structure vni-peer-group which allows the association between cp-vni-id, egress-vni and router-mac
  • Keying on both cp-vni and egress-vni allows flexibility for both symmetric and asymmetric use cases. For symmetric VNIs both keys would be set to the same value.
  • The change is backwards compatible

Tree Structure

        |           +--rw vxlan
        |              +--rw config
        |              |  +--rw description?        string
        |              |  +--rw enabled?            boolean
        |              |  +--rw source-interface?   string
        |              +--ro state
        |              |  +--ro description?        string
        |              |  +--ro enabled?            boolean
        |              |  +--ro source-interface?   string
        |              +--ro endpoint-peers
        |              |  +--ro endpoint-peer* [peer-address]
        |              |     +--ro peer-address      -> ../state/peer-address
        |              |     +--ro state
        |              |     |  +--ro peer-address?         oc-inet:ip-address
        |              |     |  +--ro peer-state?           enumeration
        |              |     |  +--ro uptime?               oc-types:timeticks64
        |              |     |  x--ro control-plane-vnis*   oc-evpn-types:vni-id
        |              |     |  x--ro router-mac?           oc-yang:mac-address
        |              |     +--ro vni-peer-group
        |              |        +--ro vni-peer-group* [cp-vni egress-vni]
        |              |           +--ro cp-vni        -> ../state/cp-vni
        |              |           +--ro egress-vni    -> ../state/egress-vni
        |              |           +--ro state
        |              |              +--ro cp-vni?       oc-evpn-types:vni-id
        |              |              +--ro egress-vni?   oc-evpn-types:vni-id
        |              |              +--ro router-mac?   oc-yang:mac-address
        |              +--ro endpoint-vnis

Platform Implementations

switch# show nve peers control-plane-vni peer-ip 203.1.1.1
Peer       VNI     Learn-Source Gateway-MAC     Peer-type  Egress-VNI SW-BD  State                 
---------  -----   ------------ --------------- ---------- ---------- -----  ----------------------
203.1.1.1  2000003 BGP          f40f.1b6f.f8db   FAB        3000003      3005   peer-vni-add-complete
  • Nokia: link to documentation
    • From the document: VNIs configured in static VXLAN instances are ‟symmetric”, that is, the same ingress and egress VNIs are used for VXLAN packets using that instance. Note that asymmetric VNIs are actually possible in EVPN VXLAN instances.

mikewiebe avatar Dec 12 '23 16:12 mikewiebe

No major YANG version changes in commit 897de89fe4240a2a580936f4fe0769814770405c

OpenConfigBot avatar Dec 12 '23 17:12 OpenConfigBot

@dplore I did a rebase and updated the name of the container as requested. There was a failure in the pyangbind step that does not seem related to my chanages.

The error states the following: Validator script failed -- infra bug?

mikewiebe avatar Feb 01 '24 17:02 mikewiebe

@dplore I did a rebase but there was a failure in the pyangbind step that does not seem related to my chanages.

The error states the following: Validator script failed -- infra bug?

mikewiebe avatar Feb 01 '24 17:02 mikewiebe

@dplore I did a rebase but there was a failure in the pyangbind step that does not seem related to my chanages.

The error states the following: Validator script failed -- infra bug?

@wenovus apologies, I pinged you for the wrong PR. This is the one where pyangbind check is failing.

dplore avatar Feb 02 '24 03:02 dplore

@dplore I did a rebase but there was a failure in the pyangbind step that does not seem related to my chanages. The error states the following: Validator script failed -- infra bug?

@wenovus apologies, I pinged you for the wrong PR. This is the one where pyangbind check is failing.

Hi @mikewiebe this seems like it might be a one-off error (maybe the cloud VM got killed) especially since the main branch is passing for this check. Can you push an empty commit to re-trigger the CI:

 git commit --allow-empty -m "Retrigger CI" && git push

wenovus avatar Feb 02 '24 04:02 wenovus

Merging into main branch for pyangbind check fix.

wenovus avatar Feb 05 '24 17:02 wenovus

@dplore I did a rebase but there was a failure in the pyangbind step that does not seem related to my chanages. The error states the following: Validator script failed -- infra bug?

@wenovus apologies, I pinged you for the wrong PR. This is the one where pyangbind check is failing.

Hi @mikewiebe this seems like it might be a one-off error (maybe the cloud VM got killed) especially since the main branch is passing for this check. Can you push an empty commit to re-trigger the CI:

 git commit --allow-empty -m "Retrigger CI" && git push

@wenovus, sorry, I was traveling last couple of weeks so just seeing this. I will try this. Thanks!

mikewiebe avatar Feb 13 '24 17:02 mikewiebe

@wenovus tried a rebase and git commit --allow-empty -m "Retrigger CI" && git push but now it's failing on a different step. public-pr (disco-idea-817). There are no details about the failure except a message Needs /gcbrun from a collaborator so unsure how to proceed. Thanks!

mikewiebe avatar Feb 21 '24 18:02 mikewiebe

/gcbrun

wenovus avatar Feb 21 '24 20:02 wenovus

@wenovus tried a rebase and git commit --allow-empty -m "Retrigger CI" && git push but now it's failing on a different step. public-pr (disco-idea-817). There are no details about the failure except a message Needs /gcbrun from a collaborator so unsure how to proceed. Thanks!

Are you able to see the "Needs /gcbrun from a collaborator" comment in the failure summary?

We recently changed the CI to only be runnable by a maintainer, so it's little cumbersome. I'll investigate whether this can be changed.

wenovus avatar Feb 21 '24 20:02 wenovus

@wenovus tried a rebase and git commit --allow-empty -m "Retrigger CI" && git push but now it's failing on a different step. public-pr (disco-idea-817). There are no details about the failure except a message Needs /gcbrun from a collaborator so unsure how to proceed. Thanks!

Are you able to see the "Needs /gcbrun from a collaborator" comment in the failure summary?

We recently changed the CI to only be runnable by a maintainer, so it's little cumbersome. I'll investigate whether this can be changed.

Ah, ok. Yes I do see the Needs /gcbrun from a collaborator comment.

mikewiebe avatar Feb 23 '24 23:02 mikewiebe

/gcbrun

dplore avatar Feb 24 '24 01:02 dplore

/gcbrun

dplore avatar Mar 12 '24 19:03 dplore

/gcbrun

dplore avatar Mar 13 '24 16:03 dplore

/gcbrun

wenovus avatar Apr 03 '24 18:04 wenovus