ondatra icon indicating copy to clipboard operation
ondatra copied to clipboard

Missing SystemGrpc_GRPC_SERVICE_GNOI Enum Constant in /gnmi/oc/enum.go

Open khrasool opened this issue 7 months ago • 2 comments

could you please add support for oc.SystemGrpc_GRPC_SERVICE_GNOI in https://github.com/openconfig/ondatra/blob/main/gnmi/oc/enum.go#L10416

example: Services: []oc.E_SystemGrpc_GRPC_SERVICE{ oc.SystemGrpc_GRPC_SERVICE_GNMI, oc.SystemGrpc_GRPC_SERVICE_GNOI, // <-- undefined error here },

I verified the enum definitions in the enum.go file, and the GNOI constant is not defined.

khrasool avatar Jun 11 '25 11:06 khrasool

These definitions are generated from the OpenConfig YANG models. I think GNOI would need to be defined similar to how GRIBI is defined here:

https://github.com/openconfig/public/blob/master/release/models/gribi/openconfig-gribi.yang

I am not sure if GNOI is missing for a good reason or not - the GNOI and GNMI services are sometimes grouped together.

I think this might be a question better suited in https://github.com/openconfig/public if GNOI should be modeled.

bstoll avatar Jul 11 '25 03:07 bstoll

This has been discussed in openconfig/public/pull/1060 - I've never gotten to updating my PR per comments from the community; @khrasool feel free to pick it up and open a new PR following the suggested model.

LimeHat avatar Jul 11 '25 06:07 LimeHat