kne icon indicating copy to clipboard operation
kne copied to clipboard

Remove references to node type

Open alexmasi opened this issue 2 years ago • 3 comments

alexmasi avatar Oct 17 '22 18:10 alexmasi

Pull Request Test Coverage Report for Build 3276772569

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 89 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.04%) to 57.926%

Files with Coverage Reduction New Missed Lines %
topo/node/ceos/ceos.go 2 44.22%
topo/node/cptx/cptx.go 3 82.47%
topo/node/node.go 84 19.74%
<!-- Total: 89
Totals Coverage Status
Change from base Build 3267338622: -0.04%
Covered Lines: 2313
Relevant Lines: 3993

💛 - Coveralls

coveralls avatar Oct 17 '22 18:10 coveralls

The linter is complaining about use of the deprecated field:

Error: SA1019: impl.Proto.Type is deprecated: Do not use.  (staticcheck)

So its safe to ignore the failure

alexmasi avatar Oct 18 '22 20:10 alexmasi

/gcbrun

alexmasi avatar Oct 18 '22 20:10 alexmasi