kne
kne copied to clipboard
openconfig
Upgrade srl controller
Pull Request Test Coverage Report for Build 3246065794
- 0 of 0 changed or added relevant lines in 0 files are covered.
- No unchanged relevant lines lost coverage.
- Overall coverage remained the same at 57.964%
| Totals | |
|---|---|
| Change from base Build 3237711793: | 0.0% |
| Covered Lines: | 2329 |
| Relevant Lines: | 4018 |
💛 - Coveralls
@hellt There is a regression with this update, the topo creation now hangs if the tag of the image is not of a certain form
@hellt There is a regression with this update, the topo creation now hangs if the tag of the image is not of a certain form
What image tag are you referring to in particular @alexmasi ?
ADD1: got it, it is the version parsing function that detects a version out of a tag. I will log this as an issue at srl-controller repo. For the moment, the workaround is to use X.Y.Z-ddddd pattern as it is tagged originally
was this superseded by another PR?
On Thu, Nov 17, 2022 at 5:33 AM Alex Masi @.***> wrote:
Closed #242 https://github.com/openconfig/kne/pull/242.
— Reply to this email directly, view it on GitHub https://github.com/openconfig/kne/pull/242#event-7828123740, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABLKV5MPFKCG7L34MDVM5HDWIVHI7ANCNFSM6AAAAAAREWSNUI . You are receiving this because you were mentioned.Message ID: @.***>
yes, however I'm hitting the control license parsing from tag issues again
will send the PR for review after I get it working