gnoi icon indicating copy to clipboard operation
gnoi copied to clipboard

Published 20 hours ago • verified publisher icon openconfig

Clarify ping RPC expected behavior

Open bstoll opened this issue 2 years ago • 4 comments

While looking into a test to verify ping behavior, I became unsure of what is expected in the PingResponse stream. It looks like it would be valid to return individual packets OR summary statistics OR both the individual packets and the summary.

This change is to clarify that summary statistics are always expected, and individual packet metrics should be returned (ie, it's probably not reasonable for a flood request).

bstoll avatar Jun 29 '22 23:06 bstoll

Pull Request Test Coverage Report for Build 2586440683

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 0.0%
Totals Coverage Status
Change from base Build 2503260217: 0.0%
Covered Lines: 0
Relevant Lines: 0
💛 - Coveralls

coveralls avatar Jun 29 '22 23:06 coveralls

Since there is no option in the PingRequest to ask for a flood ping, shall we assume that we also always request single ping stats to be returned? The way I read the spec is that both single ping responses and summary responses are expected

hellt avatar Jun 30 '22 08:06 hellt

A flood ping is specified by setting "interval" to -1.

bstoll avatar Jun 30 '22 16:06 bstoll

my bad @bstoll I can't read

hellt avatar Jun 30 '22 19:06 hellt