gnoi icon indicating copy to clipboard operation
gnoi copied to clipboard
verified publisher icon openconfig

Specify error codes for gnoi.File

Open dplore opened this issue 3 months ago • 4 comments

It's observed that implementations vary in which error codes are used when files or directories do not exist. This PR clarifies that the gRPC error code NOT_FOUND must be used for these conditions. It also provides a suggestion for mapping file errors to gRPC errors for other common error conditions as a reminder to implementors.

dplore avatar Dec 05 '25 22:12 dplore

Pull Request Test Coverage Report for Build 20143439752

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 0.0%
Totals Coverage Status
Change from base Build 20117778942: 0.0%
Covered Lines: 0
Relevant Lines: 12347
💛 - Coveralls

coveralls avatar Dec 05 '25 22:12 coveralls

looks good to me, thanks for putting this together!

brianneville avatar Dec 10 '25 20:12 brianneville

@ElodinLaarz please review!

dplore avatar Dec 11 '25 00:12 dplore

Reviewed in Dec 16, 2025 OC Operators meeting without objection. Setting last call status. This will merge on Dec 23, 2025.

dplore avatar Dec 16 '25 20:12 dplore