gnmi icon indicating copy to clipboard operation
gnmi copied to clipboard
verified publisher icon openconfig

Fix proto generation script and improper imports.

Open asauravpica8 opened this issue 3 years ago • 3 comments

The complie_protos.sh script seems to be failing right now because of the incorrect import paths in the protoc command. Some imports in the gnmi.proto, target.proto and fake.proto also fail.

There are other instances of these failures being talked about in blogs like these.

asauravpica8 avatar Feb 16 '23 15:02 asauravpica8

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Feb 16 '23 15:02 google-cla[bot]

@robshakir PTAL! 🙏

asauravpica8 avatar Feb 17 '23 18:02 asauravpica8

While we figure out the container-based proto generations as the right architecture going forward, could we accept this PR to fix broken builds in the meantime? @robshakir @n0shut @marcushines Appreciate your time 🙏

asauravpica8 avatar May 15 '23 17:05 asauravpica8

Closing as I believe this is stale now - the situation is a bit better now that we have a build toolchain pinned with Bazel.

bstoll avatar Jul 02 '25 17:07 bstoll