DP-2.4: Adding queue name as per vendor update

[charantejag504]

DP-2.4: Adding queue name as per vendor update

[gemini-code-assist[bot]]

Summary of Changes

Hello @charantejag504, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors an ingress policer test to incorporate vendor-specific queue names, moving away from a generic "DEFAULT" identifier. By leveraging the netutil package to dynamically obtain queue definitions, the change enhances the test's accuracy and robustness, ensuring it correctly validates traffic policing behavior in diverse network environments.

Highlights

• Dynamic Queue Naming: The pull request updates the ingress_police_default_test.go file to use dynamically retrieved queue names (queues.BE1, queues.BE0) instead of the hardcoded "DEFAULT" string.
• Vendor Alignment: This change is made to align with vendor updates, ensuring the test accurately reflects the specific queue configurations provided by the network device vendor.
• Netutil Package Integration: The github.com/openconfig/ondatra/netutil package is imported and utilized to fetch common traffic queue definitions, improving the test's adaptability and maintainability.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

[^1]: Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

[OpenConfigBot]

Pull Request Functional Test Report for #4787 / 1ff32afa4712e94e3517ab2882cf02a4b924dba4

Virtual Devices

Device	Test	Test Documentation	Job	Raw Log
Arista cEOS		DP-2.4: Police traffic on input matching all packets using 1 rate, 2 color marker	32ca1579	Log
Cisco 8000E		DP-2.4: Police traffic on input matching all packets using 1 rate, 2 color marker	2dab3273	Log
Cisco XRd		DP-2.4: Police traffic on input matching all packets using 1 rate, 2 color marker	ed341e66	Log
Juniper ncPTX		DP-2.4: Police traffic on input matching all packets using 1 rate, 2 color marker	976611fb	Log
Nokia SR Linux		DP-2.4: Police traffic on input matching all packets using 1 rate, 2 color marker	161b2250	Log
Openconfig Lemming		DP-2.4: Police traffic on input matching all packets using 1 rate, 2 color marker	dcf6e2bf	Log

Hardware Devices

Device	Test	Test Documentation	Raw Log
Arista 7808		DP-2.4: Police traffic on input matching all packets using 1 rate, 2 color marker
Cisco 8808		DP-2.4: Police traffic on input matching all packets using 1 rate, 2 color marker
Juniper PTX10008		DP-2.4: Police traffic on input matching all packets using 1 rate, 2 color marker
Nokia 7250 IXR-10e		DP-2.4: Police traffic on input matching all packets using 1 rate, 2 color marker

Help

[coveralls]

Pull Request Test Coverage Report for Build 19251521780

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 10.955%

---

Totals
Change from base Build 19250375359:	0.0%
Covered Lines:	2224
Relevant Lines:	20302

---

💛 - Coveralls

[dplore]

/fptest virtual