RT-2.15 Add deviation for aggregate SID counter out packets telemetry

[raviv-arista]

Added deviation for platforms (ARISTA) that do not support the OpenConfig path /network-instances/network-instance/mpls/signaling-protocols/segment-routing/aggregate-sid-counters/aggregate-sid-counter/state/out-pkts

b/449592554

[OpenConfigBot]

Pull Request Functional Test Report for #4775 / dc32196a9b94a33c81bc005a43d338705299bda0

Virtual Devices

Device	Test	Test Documentation	Job	Raw Log
Arista cEOS		RT-2.15: IS-IS Extensions for Segment Routing
Cisco 8000E		RT-2.15: IS-IS Extensions for Segment Routing
Cisco XRd		RT-2.15: IS-IS Extensions for Segment Routing
Juniper ncPTX		RT-2.15: IS-IS Extensions for Segment Routing
Nokia SR Linux		RT-2.15: IS-IS Extensions for Segment Routing
Openconfig Lemming		RT-2.15: IS-IS Extensions for Segment Routing

Hardware Devices

Device	Test	Test Documentation	Raw Log
Arista 7808		RT-2.15: IS-IS Extensions for Segment Routing
Cisco 8808		RT-2.15: IS-IS Extensions for Segment Routing
Juniper PTX10008		RT-2.15: IS-IS Extensions for Segment Routing
Nokia 7250 IXR-10e		RT-2.15: IS-IS Extensions for Segment Routing

Help

[gemini-code-assist[bot]]

Summary of Changes

Hello @raviv-arista, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request implements a new platform deviation to address a known limitation on Arista devices regarding the availability of a specific OpenConfig telemetry path for MPLS Segment Routing aggregate SID counter output packets. By introducing this deviation, the relevant test cases will now gracefully handle platforms that do not expose this data, preventing erroneous test failures and improving the robustness and compatibility of the test suite across different network device vendors.

Highlights

• New Platform Deviation: Introduced a deviation for Arista platforms that do not support the OpenConfig path for MPLS Segment Routing aggregate SID counter output packets (/network-instances/network-instance/mpls/signaling-protocols/segment-routing/aggregate-sid-counters/aggregate-sid-counter/state/out-pkts).
• Conditional Test Execution: Updated the VerifyISISSRSIDCounters test to conditionally skip checks for 'out-pkts' telemetry on devices where this deviation is enabled, preventing erroneous failures.
• Deviation Infrastructure Update: Added the necessary Go code and Protobuf definitions to support the new 'aggregate_sid_counter_out_pkts_unsupported' deviation across the system.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

[^1]: Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

[coveralls]

Pull Request Test Coverage Report for Build 19067249584

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

• For more information on this, see Tracking coverage changes with pull request builds.
• To avoid this issue with future PRs, see these Recommended CI Configurations.
• For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

• 0 of 58 (0.0%) changed or added relevant lines in 4 files are covered.
• 11 unchanged lines in 3 files lost coverage.
• Overall coverage increased (+0.07%) to 11.132%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
internal/deviations/deviations.go	0	3	0.0%
proto/nosimage_go_proto/nosimage.pb.go	0	6	0.0%
proto/metadata_go_proto/metadata.pb.go	0	23	0.0%
topologies/proto/binding/binding.pb.go	0	26	0.0%
<!--	Total:	0	58

Files with Coverage Reduction	New Missed Lines	%
proto/nosimage_go_proto/nosimage.pb.go	1	0.0%
proto/metadata_go_proto/metadata.pb.go	4	0.0%
topologies/proto/binding/binding.pb.go	6	0.0%
<!--	Total:	11

Totals
Change from base Build 19053386984:	0.07%
Covered Lines:	2224
Relevant Lines:	19978

---

💛 - Coveralls

[ram-mac]

@raviv-arista - I have validated the test and the test is not passing. Can you please take a look at the logs. Logs can be accessed in this location https://partnerissuetracker.corp.google.com/issues/449592554