featureprofiles icon indicating copy to clipboard operation
featureprofiles copied to clipboard

Add ARP wait utilities for IPv4 and IPv6 in traceroute packetin tests

Open karthikeya-remilla opened this issue 2 months ago • 3 comments

This is standard procedure used across many FNT tests after ate.OTG().StartProtocols(t).

This is needed to improve success rate of P4RT-5.1 and avoid transient ARP issues.

karthikeya-remilla avatar Oct 31 '25 10:10 karthikeya-remilla

Summary of Changes

Hello @karthikeya-remilla, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request aims to bolster the stability and success rate of traceroute packet-in tests, particularly for P4RT-5.1, by addressing transient ARP resolution issues. It achieves this by incorporating standard ARP wait utilities for both IPv4 and IPv6, ensuring that ARP entries are properly resolved after network protocols are initiated before test execution proceeds.

Highlights

  • Improved Test Reliability: Introduced explicit wait mechanisms for ARP resolution for both IPv4 and IPv6 within the traceroute packet-in tests.
  • New Utility Import: The otgutils package has been imported into traceroute_packetin_test.go to leverage its ARP waiting functionalities.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

[^1]: Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

gemini-code-assist[bot] avatar Oct 31 '25 10:10 gemini-code-assist[bot]

Pull Request Functional Test Report for #4769 / 54169408ffd5b461747bf1e079a3a294928cb7ee

Virtual Devices

Device Test Test Documentation Job Raw Log
Arista cEOS status
P4RT-5.1: Traceroute: PacketIn
Cisco 8000E status
P4RT-5.1: Traceroute: PacketIn
Cisco XRd status
P4RT-5.1: Traceroute: PacketIn
Juniper ncPTX status
P4RT-5.1: Traceroute: PacketIn
Nokia SR Linux status
P4RT-5.1: Traceroute: PacketIn
Openconfig Lemming status
P4RT-5.1: Traceroute: PacketIn

Hardware Devices

Device Test Test Documentation Raw Log
Arista 7808 status
P4RT-5.1: Traceroute: PacketIn
Cisco 8808 status
P4RT-5.1: Traceroute: PacketIn
Juniper PTX10008 status
P4RT-5.1: Traceroute: PacketIn
Nokia 7250 IXR-10e status
P4RT-5.1: Traceroute: PacketIn

Help

OpenConfigBot avatar Oct 31 '25 10:10 OpenConfigBot

Pull Request Test Coverage Report for Build 18969636485

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 11.082%

Totals Coverage Status
Change from base Build 18964170800: 0.0%
Covered Lines: 2224
Relevant Lines: 20068

💛 - Coveralls

coveralls avatar Oct 31 '25 10:10 coveralls