RT-2.12 code changes

[karthikeya-remilla]

Cisco PR for RT-2.12 as requested. Changes needed:

1. reuse existing skip_isis_set_metric_style_type for unsupported scenario. Created tracker b/456075095 and added comment in metadata.proto
2. reuse existing tc_metric_propagation_unsupported for b/388955361
3. properly configure tag-set under routing policy like how it's done in the other redistribution testcase RT-1.27: https://github.com/openconfig/featureprofiles/blob/6344e075a2e2c3ca2f82641285532ea1871919d9/feature/bgp/static_route_bgp_redistribution/otg_tests/static_route_bgp_redistribution_test/static_route_bgp_redistribution_test.go#L1073
4. the deviation if-blocks should be moved inside t.Run in order to not skip the parent testcase.

[gemini-code-assist[bot]]

Summary of Changes

Hello @karthikeya-remilla, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request implements several critical adjustments to the static_route_isis_redistribution test suite. The primary goal is to enhance the robustness and accuracy of these tests by properly handling platform-specific deviations related to IS-IS metric propagation and metric style type configuration. Additionally, it refines the routing policy tag-set configuration logic and improves the test execution flow by moving deviation checks into sub-test runs, ensuring more precise test skipping behavior.

Highlights

• Deviation Handling: Introduced new deviation handling for IS-IS metric style type and metric propagation, ensuring tests correctly account for unsupported scenarios and setting metrics to zero when propagation is unsupported.
• Routing Policy Tag-Set Configuration: Updated routing policy tag-set configuration to align with best practices, using GetOrCreate and UnionString for robustness and consistency with other redistribution test cases.
• Test Structure Improvement: Refactored test case deviation checks to be within t.Run blocks, preventing entire parent test cases from being skipped unnecessarily and allowing for more granular test execution.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

[^1]: Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

[OpenConfigBot]

Pull Request Functional Test Report for #4764 / f29a94f3aa70f9785057701f0d1bc5244877f2d1

Virtual Devices

Device	Test	Test Documentation	Job	Raw Log
Arista cEOS		RT-2.12: Static route to IS-IS redistribution	268a1057	Log
Cisco 8000E		RT-2.12: Static route to IS-IS redistribution	48447dfe	Log
Cisco XRd		RT-2.12: Static route to IS-IS redistribution	03008417	Log
Juniper ncPTX		RT-2.12: Static route to IS-IS redistribution	acb46406	Log
Nokia SR Linux		RT-2.12: Static route to IS-IS redistribution	6fd7da60	Log
Openconfig Lemming		RT-2.12: Static route to IS-IS redistribution	7e9fa2fc	Log

Hardware Devices

Device	Test	Test Documentation	Raw Log
Arista 7808		RT-2.12: Static route to IS-IS redistribution
Cisco 8808		RT-2.12: Static route to IS-IS redistribution
Juniper PTX10008		RT-2.12: Static route to IS-IS redistribution
Nokia 7250 IXR-10e		RT-2.12: Static route to IS-IS redistribution

Help

[coveralls]

Pull Request Test Coverage Report for Build 19290374200

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 10.413%

---

Totals
Change from base Build 19289044154:	0.0%
Covered Lines:	2224
Relevant Lines:	21358

---

💛 - Coveralls

[AmrNJ]

/fptest all