Adding BMP-2.8: BMP Post Policy Test

[keysightgems]

Readme Location: https://github.com/openconfig/featureprofiles/blob/main/feature/bgp/bmp/otg_tests/bmp_post_policy_test/README.md

[OpenConfigBot]

Pull Request Functional Test Report for #4761 / be89bc568d108e1fbb272753495577db440a61eb

Virtual Devices

Device	Test	Test Documentation	Job	Raw Log
Arista cEOS		BMP-2.8: BMP Post Policy Test
Cisco 8000E		BMP-2.8: BMP Post Policy Test
Cisco XRd		BMP-2.8: BMP Post Policy Test
Juniper ncPTX		BMP-2.8: BMP Post Policy Test
Nokia SR Linux		BMP-2.8: BMP Post Policy Test
Openconfig Lemming		BMP-2.8: BMP Post Policy Test

Hardware Devices

Device	Test	Test Documentation	Raw Log
Arista 7808		BMP-2.8: BMP Post Policy Test
Cisco 8808		BMP-2.8: BMP Post Policy Test
Juniper PTX10008		BMP-2.8: BMP Post Policy Test
Nokia 7250 IXR-10e		BMP-2.8: BMP Post Policy Test

Help

[gemini-code-assist[bot]]

Summary of Changes

Hello @keysightgems, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request adds a new feature profile test, BMP-2.8, which focuses on verifying BGP Monitoring Protocol (BMP) post-policy route monitoring capabilities. The changes include the core test logic, new helper functions for configuring BGP and BMP on network devices and ATEs, and updates to platform deviation handling to accommodate devices where BMP OpenConfig is not yet fully supported. This ensures robust testing of how routes are monitored after policy application.

Highlights

• New BMP Post Policy Test: Introduces bmp_post_policy_test.go to validate BGP Monitoring Protocol (BMP) post-policy route monitoring.
• BMP Configuration Utility: Adds a ConfigureBMP function in internal/cfgplugins/bgp.go to simplify BMP station configuration on DUTs, including handling for platforms that don't support OpenConfig for BMP.
• Routing Policy Helpers: New functions NonMatchingPrefixRoutePolicy and ConfigureRoutePolicyAllow are added to internal/cfgplugins/policyforwarding.go for flexible routing policy creation.
• Platform Deviation for BMP: Introduces BMPOCUnsupported deviation and updates metadata.proto to flag devices that do not support OpenConfig for BMP, specifically noting Arista.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

[^1]: Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

[coveralls]

Pull Request Test Coverage Report for Build 18877681964

Details

• 0 of 90 (0.0%) changed or added relevant lines in 4 files are covered.
• 5 unchanged lines in 2 files lost coverage.
• Overall coverage decreased (-0.002%) to 11.102%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
internal/deviations/deviations.go	0	2	0.0%
proto/metadata_go_proto/metadata.pb.go	0	20	0.0%
internal/cfgplugins/bgp.go	0	34	0.0%
internal/cfgplugins/policyforwarding.go	0	34	0.0%
<!--	Total:	0	90

Files with Coverage Reduction	New Missed Lines	%
internal/deviations/deviations.go	1	0.0%
proto/metadata_go_proto/metadata.pb.go	4	0.0%
<!--	Total:	5

Totals
Change from base Build 18877510710:	-0.002%
Covered Lines:	2224
Relevant Lines:	20033

---

💛 - Coveralls