Add test DP-2.2: QoS scheduler with 1 rate 2 color policer, classifying on next-hop group

[desaimg1]

Pausing this test as per the guidance from Darren

https://partnerissuetracker.corp.google.com/issues/451469955

[gemini-code-assist[bot]]

Summary of Changes

Hello @desaimg1, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request adds a comprehensive test for Quality of Service (QoS) ingress policing, specifically targeting scenarios where traffic classification is based on next-hop groups and a one-rate two-color policer is applied. It also enhances the configuration framework to accommodate platform-specific deviations for QoS settings, ensuring broader compatibility.

Highlights

• New QoS Test Case: Introduced ingress_police_nhg_test.go to validate QoS scheduling with a one-rate two-color policer, classifying traffic based on next-hop groups.
• MPLS-in-UDP Tunnel Hashing Validation: The new test includes specific validation for MPLS-in-UDP tunnel hashing behavior under QoS policies.
• Arista Platform Deviations: Updated metadata.textproto to include platform exceptions for Arista devices, addressing limitations in OpenConfig support for QoS two-rate three-color policers and ingress schedulers.
• QoS Policer Configuration Utility: Added NewOneRateTwoColorScheduler to internal/cfgplugins/qos.go, providing a flexible way to configure one-rate two-color policers, falling back to CLI for platforms where OpenConfig is not fully supported.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

[^1]: Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

[OpenConfigBot]

Pull Request Functional Test Report for #4753 / e8dc1c8f26fe906e888d61f8dbbdd80117566ac6

Virtual Devices

Device	Test	Test Documentation	Job	Raw Log
Arista cEOS		DP-2.2: QoS scheduler with 1 rate 2 color policer, classifying on next-hop group
Cisco 8000E		DP-2.2: QoS scheduler with 1 rate 2 color policer, classifying on next-hop group
Cisco XRd		DP-2.2: QoS scheduler with 1 rate 2 color policer, classifying on next-hop group
Juniper ncPTX		DP-2.2: QoS scheduler with 1 rate 2 color policer, classifying on next-hop group
Nokia SR Linux		DP-2.2: QoS scheduler with 1 rate 2 color policer, classifying on next-hop group
Openconfig Lemming		DP-2.2: QoS scheduler with 1 rate 2 color policer, classifying on next-hop group

Hardware Devices

Device	Test	Test Documentation	Raw Log
Arista 7808		DP-2.2: QoS scheduler with 1 rate 2 color policer, classifying on next-hop group
Cisco 8808		DP-2.2: QoS scheduler with 1 rate 2 color policer, classifying on next-hop group
Juniper PTX10008		DP-2.2: QoS scheduler with 1 rate 2 color policer, classifying on next-hop group
Nokia 7250 IXR-10e		DP-2.2: QoS scheduler with 1 rate 2 color policer, classifying on next-hop group

Help

[coveralls]

Pull Request Test Coverage Report for Build 18831230366

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

• For more information on this, see Tracking coverage changes with pull request builds.
• To avoid this issue with future PRs, see these Recommended CI Configurations.
• For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

• 0 of 36 (0.0%) changed or added relevant lines in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage decreased (-0.02%) to 11.205%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
internal/cfgplugins/qos.go	0	36	0.0%
<!--	Total:	0	36

Totals
Change from base Build 18830796776:	-0.02%
Covered Lines:	2224
Relevant Lines:	19848

---

💛 - Coveralls

[ANISH-GOTTAPU]

closing this pull request as https://github.com/openconfig/featureprofiles/pull/4918 has been raised to address the issue