openconfig
Add single topology deviation handling for ISIS.
Verified in https://github.com/openconfig/featureprofiles/pull/4703#issuecomment-3446861126.
===
This pull request adds a new helper function to handle a specific ISIS protocol deviation for single topology requirements. The main change is the introduction of logic to ensure IPv6 multi-topology settings match those of IPv4 for Cisco devices.
ISIS protocol deviation handling:
- Added the
HandleSingleTopologyDeviationfunction ininternal/cfgplugins/isis.goto set the IPv6 multi-topology AFI/SAFI to IPv4 values for Cisco devices when the single topology deviation is required. This helps maintain consistent ISIS configuration across vendors and test environments.
Summary of Changes
Hello @ElodinLaarz, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request addresses a specific ISIS protocol deviation related to single topology requirements by adding a dedicated helper function. The primary goal is to standardize ISIS configurations across different vendor environments, particularly for Cisco devices, by aligning IPv6 multi-topology settings with IPv4 when the single topology deviation is active. This change enhances consistency and simplifies testing for network configurations.
Highlights
-
New ISIS Deviation Handler: Introduced a new helper function,
HandleSingleTopologyDeviation, withininternal/cfgplugins/isis.goto manage a specific ISIS protocol deviation. - IPv6 Multi-Topology Alignment: The new function ensures that for Cisco devices requiring single topology, the IPv6 multi-topology AFI/SAFI settings are configured to match those of IPv4, promoting consistent ISIS configurations.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
[^1]: Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.
![gemini-code-assist[bot] avatar](https://avatars.githubusercontent.com/in/956858?v=4 "Published by a pub.dev verified publisher"){kind=small}
Pull Request Functional Test Report for #4751 / de5d5c6f517f00e22b17a37661d5514541115b4f
No tests identified for validation.
[!WARNING] Gemini encountered an error creating the review. You can try again by commenting
/gemini review.
Pull Request Test Coverage Report for Build 19574391773
Details
- 0 of 19 (0.0%) changed or added relevant lines in 1 file are covered.
- 1 unchanged line in 1 file lost coverage.
- Overall coverage decreased (-0.009%) to 10.103%
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
|---|---|---|---|
| internal/cfgplugins/isis.go | 0 | 19 | 0.0% |
| <!-- | Total: | 0 | 19 |
| Files with Coverage Reduction | New Missed Lines | % |
|---|---|---|
| internal/cfgplugins/isis.go | 1 | 0.0% |
| <!-- | Total: | 1 |
| Totals | |
|---|---|
| Change from base Build 19568069596: | -0.009% |
| Covered Lines: | 2227 |
| Relevant Lines: | 22042 |
💛 - Coveralls
Hi, I see 5 tests which implement the relevant deviation, but none are using the NewISIS cfgplugin. Can we show at least one use of this function which passes on Cisco DUT?
I hope you have verified that it does not break any of the existing tests. From https://github.com/openconfig/featureprofiles/pull/4751#issuecomment-3488549101, looks like it is not the case currently.
I hope you have verified that it does not break any of the existing tests. From #4751 (comment), looks like it is not the case currently.
The cfgplugin and deviation is used by Cisco in https://github.com/openconfig/featureprofiles/pull/4703 and we got a pass on Cisco HW. Will ping you.