Skip unsupported non-default VRF test cases for syslog

[karthikeya-remilla]

previous invocations of deviations.SyslogOCUnsupported inside configureSyslog led to the syslog config not being added to non-default network instance but performed other parts of config leading to test failure per the test requirements in README.

the second subtest with vrf "nondefaultvrfx" needs to skipped/deviated at the top level.

[OpenConfigBot]

Pull Request Functional Test Report for #4720 / 8786cf56d61ed2af53dd65d180b13d929ded64eb

Virtual Devices

Device	Test	Test Documentation	Job	Raw Log
Arista cEOS		TR-6.1: Remote Syslog feature config
Cisco 8000E		TR-6.1: Remote Syslog feature config
Cisco XRd		TR-6.1: Remote Syslog feature config
Juniper ncPTX		TR-6.1: Remote Syslog feature config
Nokia SR Linux		TR-6.1: Remote Syslog feature config
Openconfig Lemming		TR-6.1: Remote Syslog feature config

Hardware Devices

Device	Test	Test Documentation	Raw Log
Arista 7808		TR-6.1: Remote Syslog feature config
Cisco 8808		TR-6.1: Remote Syslog feature config
Juniper PTX10008		TR-6.1: Remote Syslog feature config
Nokia 7250 IXR-10e		TR-6.1: Remote Syslog feature config

Help

[gemini-code-assist[bot]]

Summary of Changes

Hello @karthikeya-remilla, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the testing suite for remote syslog configurations by introducing a conditional skip for test cases involving non-default Virtual Routing and Forwarding (VRF) instances. The change ensures that tests are only executed on supported configurations, preventing misleading failures and improving the overall reliability of the test results. It specifically targets scenarios where syslog is not supported on non-default VRFs, ensuring these tests are gracefully skipped rather than failing due to unsupported operations.

Highlights

• Test Case Skipping: Implemented a mechanism to explicitly skip remote syslog test cases for non-default VRFs when the device under test (DUT) does not support syslog on such configurations.
• Improved Test Reliability: Addressed previous test failures that occurred when deviations.SyslogOCUnsupported was checked too late in the configureSyslog function, leading to partial configurations and incorrect test outcomes.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

[^1]: Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

[coveralls]

Pull Request Test Coverage Report for Build 19287852370

Details

• 0 of 8 (0.0%) changed or added relevant lines in 2 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage decreased (-0.004%) to 10.413%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
internal/deviations/deviations.go	0	3	0.0%
proto/metadata_go_proto/metadata.pb.go	0	5	0.0%
<!--	Total:	0	8

Totals
Change from base Build 19287675737:	-0.004%
Covered Lines:	2224
Relevant Lines:	21358

---

💛 - Coveralls

[ram-mac]

@karthikeya-remilla - Please fix the static analysis error around the formatting.

[ram-mac]

/fptest all