featureprofiles icon indicating copy to clipboard operation
featureprofiles copied to clipboard

Remove bgp_set_med_requires_equal_ospf_set_metric deviation

Open frasieroh opened this issue 3 months ago • 3 comments

Starting in quinn-wbb, we don't need this deviation because the BGP set metric and OSPF set metric mapping is unambigious on the EOS side (when running RCF mode).

Remove it from all applicable tests.

frasieroh avatar Oct 15 '25 19:10 frasieroh

Pull Request Test Coverage Report for Build 19590967474

Details

  • 0 of 6 (0.0%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.01%) to 10.114%

Changes Missing Coverage Covered Lines Changed/Added Lines %
proto/nosimage_go_proto/nosimage.pb.go 0 6 0.0%
<!-- Total: 0 6
Files with Coverage Reduction New Missed Lines %
internal/deviations/deviations.go 1 0.0%
proto/nosimage_go_proto/nosimage.pb.go 1 0.0%
<!-- Total: 2
Totals Coverage Status
Change from base Build 19589317666: 0.01%
Covered Lines: 2227
Relevant Lines: 22019

💛 - Coveralls

coveralls avatar Oct 15 '25 19:10 coveralls

ref issue tracker 453203692

frasieroh avatar Oct 19 '25 23:10 frasieroh

The validation is successful for Arista. The changes are only specific to Arista

ram-mac avatar Nov 13 '25 14:11 ram-mac

@frasieroh - Can you please resolve the conflicts?

ram-mac avatar Nov 13 '25 14:11 ram-mac

@frasieroh - I have approved the PR. Take care of the conflicts and it should be ready to merge.

ram-mac avatar Nov 21 '25 10:11 ram-mac

@frasieroh - I have approved the PR. Take care of the conflicts and it should be ready to merge.

apologies, please check now.

frasieroh avatar Nov 22 '25 05:11 frasieroh