Implement AFT Atomic Test
This pull request implements the AFT Atomic test, as well as updating the README.md documentation for readability, improving the test objectives, procedures, and expected outcomes. The changes improve the explanation of how the atomic flag should behave in gNMI notifications during network churn events, and restructure the document for readability and completeness.
Test objectives and expected behavior:
- Expanded the summary to clearly state that the test verifies the correct setting of the
atomicflag in gNMI notifications for AFT paths, specifying when it should betrue(initial sync and link recovery) andfalse(deletes during link down events).
Test procedure and verification steps:
- Detailed the configuration variables, their defaults, and the steps for IS-IS and eBGP setup, including expected notification behaviors for initial sync and link events.
- Clarified verification steps for scenarios involving link down/up events, specifying expected notification types, presence of the
atomicflag, and route states in the DUT’s RIB and FIB.
Documentation structure and completeness:
- Reorganized sections for improved readability, using clearer headings and bullet points.
- Moved and expanded the OpenConfig path and RPC coverage section to the end of the document, listing all relevant state paths and RPCs used in the test.
/fptest virtual
Pull Request Test Coverage Report for Build 19579739887
Details
- 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
- No unchanged relevant lines lost coverage.
- Overall coverage increased (+0.001%) to 10.104%
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
|---|---|---|---|
| internal/cfgplugins/bgp.go | 0 | 1 | 0.0% |
| <!-- | Total: | 0 | 1 |
| Totals | |
|---|---|
| Change from base Build 19578466844: | 0.001% |
| Covered Lines: | 2227 |
| Relevant Lines: | 22040 |
💛 - Coveralls
Pull Request Functional Test Report for #4703 / ed8bc35eb1b0b7fe66f3c00c7721a78db37fcbc6
Virtual Devices
| Device | Test | Test Documentation | Job | Raw Log |
|---|---|---|---|---|
| Arista cEOS | AFT-3.1: AFTs Atomic Flag Check |
2e027369 | Log | |
| Cisco 8000E | AFT-3.1: AFTs Atomic Flag Check |
76af57ff | Log | |
| Cisco XRd | AFT-3.1: AFTs Atomic Flag Check |
40b5329b | Log | |
| Juniper ncPTX | AFT-3.1: AFTs Atomic Flag Check |
4acce53f | Log | |
| Nokia SR Linux | AFT-3.1: AFTs Atomic Flag Check |
7dd188ab | Log | |
| Openconfig Lemming | AFT-3.1: AFTs Atomic Flag Check |
9c2720d3 | Log |
Hardware Devices
| Device | Test | Test Documentation | Raw Log |
|---|---|---|---|
| Arista 7808 | AFT-3.1: AFTs Atomic Flag Check |
||
| Cisco 8808 | AFT-3.1: AFTs Atomic Flag Check |
||
| Juniper PTX10008 | AFT-3.1: AFTs Atomic Flag Check |
||
| Nokia 7250 IXR-10e | AFT-3.1: AFTs Atomic Flag Check |
/fptest physical
/fptest physical
/gemini review
Too many changes to review at once. Please split into multiple PRs
This PR can be used as reference to see the test is working.
Splitting library changes into separte PRs. Please take a look.
https://github.com/openconfig/featureprofiles/pull/4749
https://github.com/openconfig/featureprofiles/pull/4750
https://github.com/openconfig/featureprofiles/pull/4751
https://github.com/openconfig/featureprofiles/pull/4752