featureprofiles icon indicating copy to clipboard operation
featureprofiles copied to clipboard

Refactor gRPC dial options and SSH handling in binding.go

Open asishkbasu opened this issue 3 months ago • 2 comments

This PR updates topologies/binding/binding.go to:

  • Improved SSH flow handling include proper host and port formatting
  • Refactor gRPC dial options for better security and flexibility.
  • Updated host key verification logic
  • Added comments and error handling - debuggability

asishkbasu avatar Oct 13 '25 18:10 asishkbasu

Pull Request Functional Test Report for #4698 / ed0753ea352d457b2fc1049b989a4de8bf09316d

No tests identified for validation.

Help

OpenConfigBot avatar Oct 13 '25 18:10 OpenConfigBot

Pull Request Test Coverage Report for Build 19222535041

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 13 of 57 (22.81%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 10.993%

Changes Missing Coverage Covered Lines Changed/Added Lines %
topologies/binding/binding.go 13 57 22.81%
<!-- Total: 13 57
Totals Coverage Status
Change from base Build 19216631230: 0.04%
Covered Lines: 2237
Relevant Lines: 20350

💛 - Coveralls

coveralls avatar Oct 14 '25 04:10 coveralls