featureprofiles
featureprofiles copied to clipboard
Refactor gRPC dial options and SSH handling in binding.go
This PR updates topologies/binding/binding.go to:
- Improved SSH flow handling include proper host and port formatting
- Refactor gRPC dial options for better security and flexibility.
- Updated host key verification logic
- Added comments and error handling - debuggability
Pull Request Functional Test Report for #4698 / ed0753ea352d457b2fc1049b989a4de8bf09316d
No tests identified for validation.
Pull Request Test Coverage Report for Build 19222535041
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
- For more information on this, see Tracking coverage changes with pull request builds.
- To avoid this issue with future PRs, see these Recommended CI Configurations.
- For a quick fix, rebase this PR at GitHub. Your next report should be accurate.
Details
- 13 of 57 (22.81%) changed or added relevant lines in 1 file are covered.
- No unchanged relevant lines lost coverage.
- Overall coverage increased (+0.04%) to 10.993%
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
|---|---|---|---|
| topologies/binding/binding.go | 13 | 57 | 22.81% |
| <!-- | Total: | 13 | 57 |
| Totals | |
|---|---|
| Change from base Build 19216631230: | 0.04% |
| Covered Lines: | 2237 |
| Relevant Lines: | 20350 |