otg-rt-10.1

[crc-kt]

RT-10.1: Default Route Generation based on 192.0.0.0/8 Presence

This test aims to trigger a default route generation when a specific prefix is advertised by an eBGP neighbor.

Readme location: https://github.com/openconfig/featureprofiles/blob/main/feature/networkinstance/local_aggregates/tests/policy_advertise_aggregate/README.md

Note: Due to the fact that our setup's default config (that is loaded by the framework) has a static default route that assures the mgmt connectivity, I can't run this test in-house so I'm not able to provide a pass log for the run.

[OpenConfigBot]

Pull Request Functional Test Report for #4678 / 01ce37bb7f31805fddf6ec865e0606d22b94f5a1

Virtual Devices

Device	Test	Test Documentation	Job	Raw Log
Arista cEOS		RT-10.1: Default Route Generation based on 192.0.0.0/8 Presence
Cisco 8000E		RT-10.1: Default Route Generation based on 192.0.0.0/8 Presence
Cisco XRd		RT-10.1: Default Route Generation based on 192.0.0.0/8 Presence
Juniper ncPTX		RT-10.1: Default Route Generation based on 192.0.0.0/8 Presence
Nokia SR Linux		RT-10.1: Default Route Generation based on 192.0.0.0/8 Presence
Openconfig Lemming		RT-10.1: Default Route Generation based on 192.0.0.0/8 Presence

Hardware Devices

Device	Test	Test Documentation	Raw Log
Arista 7808		RT-10.1: Default Route Generation based on 192.0.0.0/8 Presence
Cisco 8808		RT-10.1: Default Route Generation based on 192.0.0.0/8 Presence
Juniper PTX10008		RT-10.1: Default Route Generation based on 192.0.0.0/8 Presence
Nokia 7250 IXR-10e		RT-10.1: Default Route Generation based on 192.0.0.0/8 Presence

Help

[coveralls]

Pull Request Test Coverage Report for Build 19942308951

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

• For more information on this, see Tracking coverage changes with pull request builds.
• To avoid this issue with future PRs, see these Recommended CI Configurations.
• For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

• 0 of 83 (0.0%) changed or added relevant lines in 3 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage decreased (-0.04%) to 10.074%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
internal/deviations/deviations.go	0	3	0.0%
proto/metadata_go_proto/metadata.pb.go	0	5	0.0%
internal/cfgplugins/bgp_policy.go	0	75	0.0%
<!--	Total:	0	83

Totals
Change from base Build 19923363524:	-0.04%
Covered Lines:	2227
Relevant Lines:	22106

---

💛 - Coveralls

[ram-mac]

This test is failing with the below error. Please fix this part for further validation of the PR.

[third_party/openconfig/featureprofiles/feature/networkinstance/local_aggregates/tests/policy_advertise_aggregate/policy_advertise_aggregate_test.go:100](https://cs.corp.google.com/piper///depot/google3/third_party/openconfig/featureprofiles/feature/networkinstance/local_aggregates/tests/policy_advertise_aggregate/policy_advertise_aggregate_test.go?l=100&ws=rmachat/1806&snapshot=123): Replace(t) on dut(xx59.den85) at /routing-policy: Replace(t) at path origin:"openconfig"  elem:{name:"routing-policy"}: rpc error: code = InvalidArgument desc = error on request {
        prefix:  {
          target:  "xx59.den85"
        }
        replace:  {
          path:  {
            origin:  "openconfig"
            elem:  {
              name:  "routing-policy"
            }
          }
          val:  {
            json_ietf_val:  "{\n  \"openconfig-routing-policy:defined-sets\": {\n    \"prefix-sets\": {\n      \"prefix-set\": [\n        {\n          \"config\": {\n            \"mode\": \"IPV4\",\n            \"name\": \"TRIGGER_ROUTE_PS\"\n          },\n          \"name\": \"TRIGGER_ROUTE_PS\",\n          \"prefixes\": {\n            \"prefix\": [\n              {\n                \"config\": {\n                  \"ip-prefix\": \"192.0.0.0/8\",\n                  \"masklength-range\": \"exact\"\n                },\n                \"ip-prefix\": \"192.0.0.0/8\",\n                \"masklength-range\": \"exact\"\n              }\n            ]\n          }\n        }\n      ]\n    }\n  },\n  \"openconfig-routing-policy:policy-definitions\": {\n    \"policy-definition\": [\n      {\n        \"config\": {\n          \"name\": \"GENERATE_DEFAULT\"\n        },\n        \"name\": \"GENERATE_DEFAULT\",\n        \"statements\": {\n          \"statement\": [\n            {\n              \"actions\": {\n                \"config\": {\n                  \"policy-result\": \"ACCEPT_ROUTE\"\n                },\n                \"openconfig-bgp-policy:bgp-actions\": {\n                  \"config\": {\n                    \"set-next-hop\": \"0.0.0.0\"\n                  }\n                }\n              },\n              \"conditions\": {\n                \"match-prefix-set\": {\n                  \"config\": {\n                    \"prefix-set\": \"TRIGGER_ROUTE_PS\"\n                  }\n                }\n              },\n              \"config\": {\n                \"name\": \"20\"\n              },\n              \"name\": \"20\"\n            }\n          ]\n        }\n      }\n    ]\n  }\n}"
          }
        }
        }: failed to apply: Error function openconfig GENERATE_DEFAULT line 4:17: invalid immediate ip_address_type
        4       next_hop = 0.0.0.0;
                           ^~~~~~~
        
        Compilation failed: CLI command 6 of 8 'session gnmi sync' failed: could not run command

[crc-kt]

The previous comment is resolved, but I am blocked on https://partnerissuetracker.corp.google.com/issues/455892126 (OC blocker issue)

[ram-mac]

@crc-kt - Can we please fix the static_analysis errors in the PR and also the other failure

[ANISH-GOTTAPU]

@ram-mac : Somehow CI is not triggered, can you please trigger CI from your end.

[ANISH-GOTTAPU]

@crc-kt - Can we please fix the static_analysis errors in the PR and also the other failure

fixed static analysis and other errors

[ram-mac]

@ANISH-GOTTAPU @crc-kt - I have validated the latest changes from this PR. The test seems to be still failing with the below error. Attached the full test log here https://partnerissuetracker.corp.google.com/issues/415458482

*** Creating CLI client for xxxxxxx...
      
    [third_party/openconfig/featureprofiles/internal/cfgplugins/qos.go:85]
: Failed to execute CLI command '
        configure terminal
        !
        dynamic prefix-list ipv4_generate_default
        match rcf ipv4_generate_default_conditionally()
        prefix-list ipv4 GENERATED_ROUTE
        ': gnetch command failed "\nconfigure terminal\n!\ndynamic prefix-list ipv4_generate_default\nmatch rcf ipv4_generate_default_conditionally()\nprefix-list ipv4 GENERATED_ROUTE\n": generic::unknown: invalid status gnetch::8: [http://go/gnetch-errors](https://www.google.com/url?q=http://go/gnetch-errors&sa=D): [http://gnetch/auditlog/96c7a231-dba3-4638-bdf8-f3752e1f7a33](https://www.google.com/url?q=http://gnetch/auditlog/96c7a231-dba3-4638-bdf8-f3752e1f7a33&sa=D) host=xxxxxxxx agent=/bns/pw/borg/pw/bns/gnetch/gnetch.lab_agent/1 fallback=False google3.net.infra.telemetry.gnetch.lib.exceptions.CmdError(8) <class 'pexpect.exceptions.TIMEOUT'>: Timeout (630) exceeded in read().
        <google3.net.infra.telemetry.gnetch.devices.pexpect_connection.SshSpawn object at 0x7287f06641d0>
        command: None
        args: None
        buffer (last 100 chars): b'xx58.den85(config-dyn-pfx-ipv4_generate_default)#\r\nxx58.den85(config-dyn-pfx-ipv4_generate_default)#'
        before (last 100 chars): b'xx58.den85(config-dyn-pfx-ipv4_generate_default)#\r\nxx58.den85(config-dyn-pfx-ipv4_generate_default)#'
        after: <class 'pexpect.exceptions.TIMEOUT'>
        match: None
        match_index: None
        exitstatus: None
        flag_eof: False
        pid: None
        child_fd: None
        closed: False
        timeout: 30
        logfile: None
        logfile_read: None
        logfile_send: None
        maxread: 8192
        ignorecase: False
        searchwindowsize: None
        delaybeforesend: 0.05
        delayafterclose: 0.1
        delayafterterminate: 0.1
        searcher: searcher_re:
            0: re.compile(b'(?:^|[\\n}])xx58\\.den85\\#')
            1: re.compile(b'\\[confirm\\]$|\\[yes/no/cancel/diff\\]:$')

[ANISH-GOTTAPU]

@ram-mac : I couldn't see the log in https://partnerissuetracker.corp.google.com/issues/415458482, can you please check once.

[ANISH-GOTTAPU]

@ram-mac : I couldn't see the log in https://partnerissuetracker.corp.google.com/issues/415458482, can you please check once.

I am able to find the log, I will try to put the same image as in the log and check.

[ANISH-GOTTAPU]

@ram-mac : I couldn't see the log in https://partnerissuetracker.corp.google.com/issues/415458482, can you please check once.

I am able to find the log, I will try to put the same image as in the log and check.

@ram-mac : I ran with new version and test is passing for me. Attached the log here https://partnerissuetracker.corp.google.com/issues/415458482#comment129

[ram-mac]

@ANISH-GOTTAPU - just FYI; Please take a look at the previous comment and take action accordingly.

@crc-kt - Once you make changes, please do resolve the conflicts