featureprofiles icon indicating copy to clipboard operation
featureprofiles copied to clipboard

Fixed authz test issue mentioned in #2770 and addressing conflict issue #3117

Open Eeramma opened this issue 3 months ago • 5 comments

Fixed authz test issue mentioned in #2770 and addressing conflict issue #3117. To clear CLA failure problem in #3117 for an unexpected commit by "root" raising new pull request for same modifications as in #3117 which is already approved.

Eeramma avatar Sep 26 '25 04:09 Eeramma

Pull Request Functional Test Report for #4648 / 9e0686083508d5c7c251297836888e8ca5412a1a

Virtual Devices

Device Test Test Documentation Job Raw Log
Arista cEOS status
Authz: General Authz (1-4) tests
Cisco 8000E status
Authz: General Authz (1-4) tests
Cisco XRd status
Authz: General Authz (1-4) tests
Juniper ncPTX status
Authz: General Authz (1-4) tests
Nokia SR Linux status
Authz: General Authz (1-4) tests
Openconfig Lemming status
Authz: General Authz (1-4) tests

Hardware Devices

Device Test Test Documentation Raw Log
Arista 7808 status
Authz: General Authz (1-4) tests
Cisco 8808 status
Authz: General Authz (1-4) tests
Juniper PTX10008 status
Authz: General Authz (1-4) tests
Nokia 7250 IXR-10e status
Authz: General Authz (1-4) tests

Help

OpenConfigBot avatar Sep 26 '25 04:09 OpenConfigBot

Pull Request Test Coverage Report for Build 19266126718

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 60 (0.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 10.396%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/security/authz/authz.go 0 26 0.0%
internal/security/gnxi/rpcexec.go 0 34 0.0%
<!-- Total: 0 60
Totals Coverage Status
Change from base Build 19262752002: -0.02%
Covered Lines: 2224
Relevant Lines: 21392

💛 - Coveralls

coveralls avatar Oct 03 '25 06:10 coveralls

github.com/openconfig/featureprofiles/internal/security/gnxi

Error: internal/security/gnxi/rpcexec.go:395:2: unreachable code Error: internal/security/gnxi/rpcexec.go:483:2: unreachable code Error: Process completed with exit code 1.

probably should fix that.

morrowc avatar Oct 06 '25 14:10 morrowc

I'd point out that my comment today is the same comment I made last week... which you resolved without taking any action.

that sort of behavior is not terrific.

morrowc avatar Oct 06 '25 15:10 morrowc

I'd point out that my comment today is the same comment I made last week... which you resolved without taking any action.

that sort of behavior is not terrific.

Previously I observed that the comment was made for the code block line# 590 & #618 the new git merge has this change.
Now I see the unreachable code is in different block which was not listed earlier. The changes are in progress.

Eeramma avatar Oct 06 '25 16:10 Eeramma

@Eeramma - I have validated this PR in google setup and the test is still failing. I have provided the logs to @lvaish05

ram-mac avatar Nov 11 '25 07:11 ram-mac

@Eeramma - I have validated this PR in google setup and the test is still failing. I have provided the logs to @lvaish05

Hi, there were gaps in understanding the topology requirements. Could you please share latest logs

Eeramma avatar Dec 15 '25 04:12 Eeramma