featureprofiles icon indicating copy to clipboard operation
featureprofiles copied to clipboard

CNTR-2 Fixes

Open MarcCharlebois opened this issue 3 months ago • 4 comments

(m) cntr_test.go

  • add function to wait for containerReadiness to avoid repeated code
  • add deviation to push interfaces to default vrf
  • add wait for containerReadiness for final subtest
  • add handling for Nokia's Linux interface names.

(m) cntrsrv.go

  • let client gracefully handle EOF for empty getResponse

(m) metadata.textproto

  • add nokia deviation

"This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."

MarcCharlebois avatar Sep 18 '25 15:09 MarcCharlebois

Pull Request Functional Test Report for #4609 / b6437f91442638f2bfc49f37a62d7d484c12e30d

Virtual Devices

Device Test Test Documentation Job Raw Log
Arista cEOS status
CNTR-2: Container network connectivity tests
Cisco 8000E status
CNTR-2: Container network connectivity tests
Cisco XRd status
CNTR-2: Container network connectivity tests
Juniper ncPTX status
CNTR-2: Container network connectivity tests
Nokia SR Linux status
CNTR-2: Container network connectivity tests
Openconfig Lemming status
CNTR-2: Container network connectivity tests

Hardware Devices

Device Test Test Documentation Raw Log
Arista 7808 status
CNTR-2: Container network connectivity tests
Cisco 8808 status
CNTR-2: Container network connectivity tests
Juniper PTX10008 status
CNTR-2: Container network connectivity tests
Nokia 7250 IXR-10e status
CNTR-2: Container network connectivity tests

Help

OpenConfigBot avatar Sep 18 '25 15:09 OpenConfigBot

Pull Request Test Coverage Report for Build 19084122820

Details

  • 0 of 3 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 11.065%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/cntrsrv/cntrsrv.go 0 3 0.0%
<!-- Total: 0 3
Totals Coverage Status
Change from base Build 19082699944: 0.0%
Covered Lines: 2224
Relevant Lines: 20100

💛 - Coveralls

coveralls avatar Sep 18 '25 16:09 coveralls

Need approval from @openconfig/featureprofiles-approvers to merge the changes

nsadhasivam avatar Oct 13 '25 15:10 nsadhasivam

@rohit-rp Have you had a chance to review this PR?

MarcCharlebois avatar Nov 06 '25 22:11 MarcCharlebois