featureprofiles icon indicating copy to clipboard operation
featureprofiles copied to clipboard

TE-16.2: encapsulation FRR scenarios changes incorporated.

Open ampattan opened this issue 7 months ago • 7 comments

Updated metadata.textproto

  • Added ExplicitInterfaceInDefaultVRF
  • Added NoEcmpWithEncapDecapNhMix

Updated gribi_route_test.go

  • Add the 0/0 route in encap_te_vrf_a as part of gribi base config so that it will be part of all tests.
  • Deviation NoEcmpWithEncapDecapNhMix added for TC2-primaryBackupSingle & TC3-primaryBackupRoutingSingle.

Updated README.md

  • fallback route to redirect to DEFAULT vrf.

Updated Deviation.go ,metadata.proto & metadata.pb.go

A new deviation has been included due to mixed encap and decap next hops are not supported.

"This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."

ampattan avatar Jun 10 '25 08:06 ampattan

Pull Request Functional Test Report for #4270 / 69b0b406089b3f5b64a6d069dc8365434bf4e332

Virtual Devices

Device Test Test Documentation Job Raw Log
Arista cEOS status
TE-16.2: encapsulation FRR scenarios
Cisco 8000E status
TE-16.2: encapsulation FRR scenarios
Cisco XRd status
TE-16.2: encapsulation FRR scenarios
Juniper ncPTX status
TE-16.2: encapsulation FRR scenarios
Nokia SR Linux status
TE-16.2: encapsulation FRR scenarios
Openconfig Lemming status
TE-16.2: encapsulation FRR scenarios

Hardware Devices

Device Test Test Documentation Raw Log
Arista 7808 status
TE-16.2: encapsulation FRR scenarios
Cisco 8808 status
TE-16.2: encapsulation FRR scenarios
Juniper PTX10008 status
TE-16.2: encapsulation FRR scenarios
Nokia 7250 IXR-10e status
TE-16.2: encapsulation FRR scenarios

Help

OpenConfigBot avatar Jun 10 '25 08:06 OpenConfigBot

Pull Request Test Coverage Report for Build 19360368611

Details

  • 0 of 12 (0.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.004%) to 10.288%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/vrfpolicy/vrfpolicy.go 0 1 0.0%
proto/metadata_go_proto/metadata.pb.go 0 5 0.0%
internal/deviations/deviations.go 0 6 0.0%
<!-- Total: 0 12
Totals Coverage Status
Change from base Build 19357318501: -0.004%
Covered Lines: 2224
Relevant Lines: 21618

💛 - Coveralls

coveralls avatar Jun 10 '25 08:06 coveralls

PR in draft state, please share the changes for review once the changes are pushed

nsadhasivam avatar Jul 15 '25 12:07 nsadhasivam

/fptest virtual

nsadhasivam avatar Oct 13 '25 11:10 nsadhasivam

/fptest physical

nsadhasivam avatar Oct 13 '25 11:10 nsadhasivam

@nikki-blr Please assign @openconfig/featureprofiles-owner-gribi to review the PR

nsadhasivam avatar Oct 13 '25 11:10 nsadhasivam

Thank you ampattan@! there is one more unintentional change I think?

Just to point out - the main question I have is around finding a reference to the underlying discussion for the new deviation - I want to understand whether this is planned to be fixed in the future images and the timeline for the fix (see issue 437880737). Thank you!

@gggsmith Nokia team is currently discussing this. We’ll provide an update along with the respective Buganizer. Thank you!

ampattan avatar Oct 30 '25 14:10 ampattan

[README Canonical OC] check needs to be fixed.

gggsmith avatar Nov 12 '25 00:11 gggsmith

[README Canonical OC] check needs to be fixed.

Comment Addressed.

ampattan avatar Nov 14 '25 10:11 ampattan