featureprofiles icon indicating copy to clipboard operation
featureprofiles copied to clipboard

Adding PF-1.11 Rewrite the ingress inner packet TTL Test

Open keysightgems opened this issue 7 months ago • 7 comments

Readme Location: https://github.com/openconfig/featureprofiles/blob/main/feature/policy_forwarding/encapsulation/otg_tests/inner_ttl_ipv4/README.md

Deviation is added as part of the test (https://partnerissuetracker.corp.google.com/u/1/issues/420405305)

The logs is attached here: https://partnerissuetracker.corp.google.com/u/1/issues/415458482

keysightgems avatar May 26 '25 20:05 keysightgems

Pull Request Functional Test Report for #4241 / e01932c30601eaef81199b82831645b7fa6593b9

Virtual Devices

Device Test Test Documentation Job Raw Log
Arista cEOS status
PF-1.11: Rewrite the ingress innner packet TTL
Cisco 8000E status
PF-1.11: Rewrite the ingress innner packet TTL
Cisco XRd status
PF-1.11: Rewrite the ingress innner packet TTL
Juniper ncPTX status
PF-1.11: Rewrite the ingress innner packet TTL
Nokia SR Linux status
PF-1.11: Rewrite the ingress innner packet TTL
Openconfig Lemming status
PF-1.11: Rewrite the ingress innner packet TTL

Hardware Devices

Device Test Test Documentation Raw Log
Arista 7808 status
PF-1.11: Rewrite the ingress innner packet TTL
Cisco 8808 status
PF-1.11: Rewrite the ingress innner packet TTL
Juniper PTX10008 status
PF-1.11: Rewrite the ingress innner packet TTL
Nokia 7250 IXR-10e status
PF-1.11: Rewrite the ingress innner packet TTL

Help

OpenConfigBot avatar May 26 '25 20:05 OpenConfigBot

will open the PR once readme updates from PR https://github.com/openconfig/featureprofiles/pull/4436 are accommodated.

ANISH-GOTTAPU avatar Jul 24 '25 04:07 ANISH-GOTTAPU

@keysightgems : #4436 is merged, you can update the test accordingly and open the PR

ANISH-GOTTAPU avatar Aug 06 '25 05:08 ANISH-GOTTAPU

Pull Request Test Coverage Report for Build 20370455371

Details

  • 20 of 157 (12.74%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 10.061%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/iputil/iputil.go 20 26 76.92%
internal/cfgplugins/staticnexthop.go 0 29 0.0%
internal/cfgplugins/staticroute.go 0 31 0.0%
internal/cfgplugins/policyforwarding.go 0 71 0.0%
<!-- Total: 20 157
Totals Coverage Status
Change from base Build 20355399115: 0.03%
Covered Lines: 2247
Relevant Lines: 22333

💛 - Coveralls

coveralls avatar Sep 05 '25 09:09 coveralls

@trlongth The following issues were seen in the README. They were fixed, but the problem still persists. Please fix the README accordingly. Thanks!

  1. Issue with the line /network-instances/network-instance/protocols/protocol/static-routes/static/next-hop-group/name — it had to be commented out.
  2. Faced an issue with ip-ttl: Error — unexpected field error."

keysightgems avatar Sep 09 '25 11:09 keysightgems

@ccie57960, Addressed all the review comments and fixed. Find the latest logs here: https://partnerissuetracker.corp.google.com/u/1/issues/415458482

keysightgems avatar Sep 30 '25 02:09 keysightgems

@trlongth, Addressed all the above review comments and fixed the issues. Added the missing VRF static routes and validated TTL behavior. As per the README, configured separate match and unmatch IPs; however, TTL validation is performed only for match and unmatch cases.

And noticed the below error in the Readme, please help to fix the issue. Thanks! "container action (type *oc.NetworkInstance_PolicyForwarding_Policy_Rule_Action): JSON contains unexpected field [ip-ttl next-hop-group]"

Find the latest attached logs here : https://partnerissuetracker.corp.google.com/u/1/issues/415458482

keysightgems avatar Oct 08 '25 09:10 keysightgems

@trlongth Fixed the above all review comments and committed the code. Please find the latest logs here https://partnerissuetracker.corp.google.com/u/1/issues/415458482

Please help to resolve the README issue, as I’m not sure what’s causing it.

keysightgems avatar Nov 11 '25 14:11 keysightgems

@dplore We run into this error: "E1111 14:38:44.939640 4692 validate_readme_canonicalocspec.go:145] file feature/policy_forwarding/encapsulation/otg_tests/inner_ttl_ipv4/README.md: parent container action (type *oc.NetworkInstance_PolicyForwarding_Policy_Rule_Action): JSON contains unexpected field [ip-ttl next-hop-group]"

Checking the OC, it looks like the /network-instances/network-instance/policy-forwarding/policies/policy/rules/rule/action/config/ip-ttl is still not available yet: https://openconfig.net/projects/models/schemadocs/yangdoc/openconfig-network-instance.html#network-instances-network-instance-policy-forwarding-policies-policy-rules-rule-action-config

Is there something we need to do to mark the path available?

Also, the /network-instances/network-instance/policy-forwarding/policies/policy/rules/rule/action/config/next-hop-group is already there but the error still reports unexpected field next-hop-group.

trlongth avatar Dec 02 '25 06:12 trlongth

@dplore We run into this error: "E1111 14:38:44.939640 4692 validate_readme_canonicalocspec.go:145] file feature/policy_forwarding/encapsulation/otg_tests/inner_ttl_ipv4/README.md: parent container action (type *oc.NetworkInstance_PolicyForwarding_Policy_Rule_Action): JSON contains unexpected field [ip-ttl next-hop-group]"

Checking the OC, it looks like the /network-instances/network-instance/policy-forwarding/policies/policy/rules/rule/action/config/ip-ttl is still not available yet: https://openconfig.net/projects/models/schemadocs/yangdoc/openconfig-network-instance.html#network-instances-network-instance-policy-forwarding-policies-policy-rules-rule-action-config

Is there something we need to do to mark the path available?

Also, the /network-instances/network-instance/policy-forwarding/policies/policy/rules/rule/action/config/next-hop-group is already there but the error still reports unexpected field next-hop-group.

Yes, we do need a new release of OC public and import into ondatra. I just now created OC public data model release v5.5.0. We'll next update ondatra to use it and then this will be fixed. If there are no issues, it should be finished in about 1 day (Dec 3rd, 2025).

dplore avatar Dec 03 '25 04:12 dplore

@dplore We run into this error: "E1111 14:38:44.939640 4692 validate_readme_canonicalocspec.go:145] file feature/policy_forwarding/encapsulation/otg_tests/inner_ttl_ipv4/README.md: parent container action (type *oc.NetworkInstance_PolicyForwarding_Policy_Rule_Action): JSON contains unexpected field [ip-ttl next-hop-group]" Checking the OC, it looks like the /network-instances/network-instance/policy-forwarding/policies/policy/rules/rule/action/config/ip-ttl is still not available yet: https://openconfig.net/projects/models/schemadocs/yangdoc/openconfig-network-instance.html#network-instances-network-instance-policy-forwarding-policies-policy-rules-rule-action-config Is there something we need to do to mark the path available? Also, the /network-instances/network-instance/policy-forwarding/policies/policy/rules/rule/action/config/next-hop-group is already there but the error still reports unexpected field next-hop-group.

Yes, we do need a new release of OC public and import into ondatra. I just now created OC public data model release v5.5.0. We'll next update ondatra to use it and then this will be fixed. If there are no issues, it should be finished in about 1 day (Dec 3rd, 2025).

@keysightgems Hi, ondatra is now updated. You will need to resync your repository and this should now work

dplore avatar Dec 08 '25 19:12 dplore

@keysightgems

@dplore I am waiting for the PR https://github.com/openconfig/featureprofiles/pull/4886 to get merged.

keysightgems avatar Dec 09 '25 06:12 keysightgems

@dplore, @trlongth The above issue was fixed after resyncing the repository, but I am now getting the following errors:

  1. I received the first error, which was resolved by updating the value from "MATCH_ACTION" to "PBR_POLICY".

    E1210 02:38:22.888996 4792 validate_readme_canonicalocspec.go:145] file feature/policy_forwarding/encapsulation/otg_tests/inner_ttl_ipv4/README.md: MATCH_ACTION is not a valid value for enum field Type, type oc.E_Policy_Type

  2. I am now seeing another error. I tried to fix it but wasn’t able to. Please check and help resolve the issue.

    ########## Validating READMEs in changed directories: I1210 04:35:37.747988 4722 validate_readme_canonicalocspec.go:138] Validating "feature/policy_forwarding/encapsulation/otg_tests/inner_ttl_ipv4/README.md" E1210 04:35:37.749706 4722 validate_readme_canonicalocspec.go:145] file feature/policy_forwarding/encapsulation/otg_tests/inner_ttl_ipv4/README.md: parent container next-hop-group (type *oc.NetworkInstance_Protocol_Static_NextHopGroup): JSON contains unexpected field name F1210 04:35:37.750029 4722 validate_readme_canonicalocspec.go:164] The following files have errors:

keysightgems avatar Dec 10 '25 05:12 keysightgems

@dplore

Addressed all the comments and fixed. Attached latest logs here https://partnerissuetracker.corp.google.com/u/1/issues/415458482

keysightgems avatar Dec 18 '25 06:12 keysightgems