featureprofiles icon indicating copy to clipboard operation
featureprofiles copied to clipboard

PF-1.1: Creating test for Match condition (TZ-bit) and indirect next-hop

Open ANISH-GOTTAPU opened this issue 9 months ago • 1 comments

Readme Location: https://github.com/openconfig/featureprofiles/blob/main/feature/policy_forwarding/otg_tests/match_dscp_indirect_next_hop/README.md

Since this is the first time I raised issue with deviation, not sure if metadata pb file should be added or will be generated automatically. Please let me know if generated pb file should be added as part of the PR.

ANISH-GOTTAPU avatar Apr 10 '25 09:04 ANISH-GOTTAPU

Pull Request Test Coverage Report for Build 16438780017

Details

  • 0 of 11 (0.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.009%) to 13.461%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/deviations/deviations.go 0 3 0.0%
internal/helpers/helpers.go 0 3 0.0%
proto/metadata_go_proto/metadata.pb.go 0 5 0.0%
<!-- Total: 0 11
Totals Coverage Status
Change from base Build 16438211376: -0.009%
Covered Lines: 2065
Relevant Lines: 15341

💛 - Coveralls

coveralls avatar Jun 09 '25 10:06 coveralls

/fptest virtual

nikki-blr avatar Jun 12 '25 11:06 nikki-blr

Hi @ANISH-GOTTAPU , Can we please fix the merge conflicts?

singhavnish2516 avatar Jun 13 '25 08:06 singhavnish2516

Hi @ANISH-GOTTAPU , Can we please fix the merge conflicts?

Resolved the conflict, Thanks.

ANISH-GOTTAPU avatar Jun 14 '25 14:06 ANISH-GOTTAPU

Hi @ANISH-GOTTAPU, Can you please take a look at this PR: https://github.com/openconfig/featureprofiles/pull/4311/files? I think you will also have to make these changes in your PR. Please feel free to contact @rohit-rp if you need to understand the issue.

singhavnish2516 avatar Jun 19 '25 16:06 singhavnish2516

@rohit-rp : Should I use this deviation "fr_breakout_fix: true" in this test also?

ANISH-GOTTAPU avatar Jun 26 '25 09:06 ANISH-GOTTAPU

Can you please resolve the merge conflicts?

singhavnish2516 avatar Jul 22 '25 04:07 singhavnish2516

Can you please resolve the merge conflicts?

Resolved the conflicts. Thanks

ANISH-GOTTAPU avatar Jul 22 '25 06:07 ANISH-GOTTAPU

/fptest all

singhavnish2516 avatar Jul 22 '25 06:07 singhavnish2516