featureprofiles icon indicating copy to clipboard operation
featureprofiles copied to clipboard

RT-7.5: Update link_bandwidth_test

Open yini101 opened this issue 9 months ago • 4 comments

Add a new deviation match_link_bandwidth_regex_diff_prefix to change the linkbw_any regex matching as it might be different per device.

Update the test to use BgpPolicy_BgpSetCommunityOptionType_REPLACE instead of REMOVE then ADD the extended community.

yini101 avatar Mar 24 '25 23:03 yini101

@yini101 Link-bandwidth is the standard identifier for Extended Community. Any reason why regex alone has a different string as the same string does work for "link-bandwidth:23456:1M and link-bandwidth:23456:2G any reason why regex has a different string? We could use the deviation for interim but it will be better if we can standardize this.

AmrNJ avatar Apr 05 '25 07:04 AmrNJ

@yini101 Link-bandwidth is the standard identifier for Extended Community. Any reason why regex alone has a different string as the same string does work for "link-bandwidth:23456:1M and link-bandwidth:23456:2G any reason why regex has a different string? We could use the deviation for interim but it will be better if we can standardize this.

The lbw: prefix is the existing link bandwidth matching behavior in EOS for a long time now. It has been the behavior prior to the https://github.com/openconfig/public/pull/1027 merging into OpenConfig. The other issue is that bgp-ext-community-type is for pushing in link bandwidth as a restricted string that can be parsed, thus that part could be enforced to use link-bandwidth: from the operator's input. Internally, it's easy to parse the input link-bandwidth: for the set ext-community side; however, for match ext-community reg-exp, it's not a good idea to change the reg-exp string that's defined by the operator as that could be very problematic.

I also could not find any clear standard on what to match against in the BGP RFC.

yini101 avatar Apr 07 '25 01:04 yini101

Pull Request Test Coverage Report for Build 15701771418

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 13.911%

Totals Coverage Status
Change from base Build 15699852051: 0.0%
Covered Lines: 1985
Relevant Lines: 14269

💛 - Coveralls

coveralls avatar Apr 09 '25 22:04 coveralls

Hi @yini101 I think it will be better if we create a extendedCommunitySet for Arista with the right regex like how we have for other vendors.

AmrNJ avatar Apr 22 '25 03:04 AmrNJ

Hi @yini101 I think it will be better if we create a extendedCommunitySet for Arista with the right regex like how we have for other vendors.

I changed it as per suggested.

yini101 avatar May 01 '25 06:05 yini101

This PR has absorbed #4222 for it to pass.

yini101 avatar May 28 '25 22:05 yini101

/fptest virtual

AmrNJ avatar May 29 '25 05:05 AmrNJ

@AmrNJ Is there anything else that needs to be done on my end for this to merge? I think I resolved all of the issues. The PR Approval Workflow / check-approvals (pull_request_target) check is still failing.

yini101 avatar Jun 02 '25 23:06 yini101

It looks like PR Approval Workflow / check-approvals (pull_request_target) failed with:

RequestError [HttpError]: API rate limit exceeded for user ID 9576078. If you reach out to GitHub Support for help, please include the request ID 0401:244F27:186F2D6:30D2423:68508827 and timestamp 2025-06-16 21:09:59 UTC.

Can someone PTAL? Otherwise this has been ready to merge for a couple of weeks.

yini101 avatar Jun 16 '25 22:06 yini101