featureprofiles icon indicating copy to clipboard operation
featureprofiles copied to clipboard

RT1dot12: updated the script with gNMI watch to verify received MED

Open bkreddy143 opened this issue 10 months ago • 12 comments

  1. added watch to verify MED value for received prefixes
  2. restricted the port status check to the ports that has OTG config
  3. added deviation for bgp instance name
  4. Removed port speed deviation

"This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."

bkreddy143 avatar Mar 05 '25 03:03 bkreddy143

Pull Request Functional Test Report for #3866 / 1373816821adeb727905464156b6e6932265ac75

Virtual Devices

Device Test Test Documentation Job Raw Log
Arista cEOS status
RT-1.12: BGP always compare MED
Cisco 8000E status
RT-1.12: BGP always compare MED
Cisco XRd status
RT-1.12: BGP always compare MED
Juniper ncPTX status
RT-1.12: BGP always compare MED
Nokia SR Linux status
RT-1.12: BGP always compare MED
Openconfig Lemming status
RT-1.12: BGP always compare MED

Hardware Devices

Device Test Test Documentation Raw Log
Arista 7808 status
RT-1.12: BGP always compare MED
Cisco 8808 status
RT-1.12: BGP always compare MED
Juniper PTX10008 status
RT-1.12: BGP always compare MED
Nokia 7250 IXR-10e status
RT-1.12: BGP always compare MED

Help

OpenConfigBot avatar Mar 05 '25 03:03 OpenConfigBot

Pull Request Test Coverage Report for Build 19339564826

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 10.356%

Totals Coverage Status
Change from base Build 19339397960: 0.0%
Covered Lines: 2224
Relevant Lines: 21476

💛 - Coveralls

coveralls avatar Mar 05 '25 03:03 coveralls

Is this approved @nsadhasivam

ksgireesha avatar Mar 17 '25 09:03 ksgireesha

Image that is shared does not support oc.BgpPolicy_BgpSetMedAction_SET, to verify on 69530 onwards once available

nsadhasivam avatar Mar 26 '25 12:03 nsadhasivam

Image that is shared does not support oc.BgpPolicy_BgpSetMedAction_SET, to verify on 69530 onwards once available

Available now @nsadhasivam

MarcCharlebois avatar Apr 08 '25 17:04 MarcCharlebois

/fptest virtual

nsadhasivam avatar Jun 12 '25 08:06 nsadhasivam

/fptest virtual

nsadhasivam avatar Jun 23 '25 05:06 nsadhasivam

/fptest virtual

nsadhasivam avatar Jun 23 '25 18:06 nsadhasivam

/fptest virtual

nsadhasivam avatar Aug 25 '25 01:08 nsadhasivam

@ram-mac Can you please review this PR

nsadhasivam avatar Oct 29 '25 06:10 nsadhasivam

@ram-mac @ksgireesha , could you please approe the PR if there are no futher comments.

bkreddy143 avatar Nov 04 '25 15:11 bkreddy143

@bkreddy143 - With the changes in this PR the test causing regression for other vendors --- FAIL: TestAlwaysCompareMED (560.19s) --- PASS: TestAlwaysCompareMED/Configure_DUT_interfaces (8.91s) --- PASS: TestAlwaysCompareMED/Configure_DEFAULT_network_instance (2.60s) --- FAIL: TestAlwaysCompareMED/Configure_BGP_Neighbors (3.31s) --- PASS: TestAlwaysCompareMED/Configure_SET_MED_on_DUT (1.45s) --- PASS: TestAlwaysCompareMED/Configure_always_compare_med_on_DUT (0.72s) --- PASS: TestAlwaysCompareMED/Configure_OTG (47.47s) --- PASS: TestAlwaysCompareMED/Verify_port_status_on_DUT (3.76s) --- FAIL: TestAlwaysCompareMED/Verify_BGP_telemetry (61.69s) --- FAIL: TestAlwaysCompareMED/Verify_received_BGP_routes_at_ATE_Port_1_have_lowest_MED (123.24s) --- FAIL: TestAlwaysCompareMED/Send_and_validate_traffic_from_ATE_Port1 (82.15s) --- PASS: TestAlwaysCompareMED/Remove_MED_settings_on_DUT (1.79s) --- FAIL: TestAlwaysCompareMED/Verify_MED_on_received_routes_at_ATE_Port1_after_removing_MED_settings (120.42s) --- FAIL: TestAlwaysCompareMED/Send_and_verify_traffic_after_removing_MED_settings_on_DUT (80.15s)

Original code without your PR changes. --- PASS: TestAlwaysCompareMED (277.81s) --- PASS: TestAlwaysCompareMED/Configure_DUT_interfaces (16.22s) --- PASS: TestAlwaysCompareMED/Configure_DEFAULT_network_instance (2.30s) --- PASS: TestAlwaysCompareMED/Configure_BGP_Neighbors (9.31s) --- PASS: TestAlwaysCompareMED/Configure_SET_MED_on_DUT (4.81s) --- PASS: TestAlwaysCompareMED/Configure_always_compare_med_on_DUT (2.48s) --- PASS: TestAlwaysCompareMED/Configure_OTG (34.97s) --- PASS: TestAlwaysCompareMED/Verify_port_status_on_DUT (5.36s) --- PASS: TestAlwaysCompareMED/Verify_BGP_telemetry (11.25s) --- PASS: TestAlwaysCompareMED/Verify_received_BGP_routes_at_ATE_Port_1_have_lowest_MED (5.25s) --- PASS: TestAlwaysCompareMED/Send_and_validate_traffic_from_ATE_Port1 (84.14s) --- PASS: TestAlwaysCompareMED/Remove_MED_settings_on_DUT (5.30s) --- PASS: TestAlwaysCompareMED/Verify_MED_on_received_routes_at_ATE_Port1_after_removing_MED_settings (3.81s) --- PASS: TestAlwaysCompareMED/Send_and_verify_traffic_after_removing_MED_settings_on_DUT (80.90s)

ram-mac avatar Nov 07 '25 05:11 ram-mac

@ram-mac , could you please approve if there are no further comments.

bkreddy143 avatar Nov 12 '25 15:11 bkreddy143

/fptest all

ram-mac avatar Nov 13 '25 04:11 ram-mac

@ram-mac , could you please approve if there are no further comments.

@bkreddy143 - I have triggered a /fptest all. Have you tested locally to check if it passing?

ram-mac avatar Nov 13 '25 04:11 ram-mac

@bkreddy143 - The port status validation is failing with the new changes. Take a look at the Cisco logs for reference -https://storage.cloud.google.com/featureprofiles-ci-logs-cisco/log-a591e97d-8702-4047-98f9-467d9d72bac5.txt

Can you check this part?

ram-mac avatar Nov 13 '25 05:11 ram-mac

@bkreddy143 - The port status validation is failing with the new changes. Take a look at the Cisco logs for reference -https://storage.cloud.google.com/featureprofiles-ci-logs-cisco/log-a591e97d-8702-4047-98f9-467d9d72bac5.txt

Can you check this part?

@ram-mac , iam not able to access the logs, can we ask cisco team to debug , they might some port settign to bringup interface ? As mentioend earliar , test is using only 3 ports and it is possible that 4th port in topology might need some config .

Also, i did valdiated the changes locally on nokia box before pushing the changes.

bkreddy143 avatar Nov 13 '25 16:11 bkreddy143

@bkreddy143 - Never mind, i retested it again locally and the test now is passing with the changes. Will approve and merge the PR

ram-mac avatar Nov 14 '25 07:11 ram-mac