featureprofiles icon indicating copy to clipboard operation
featureprofiles copied to clipboard

Transceiver-9: improving test flow

Open karthikeya-remilla opened this issue 1 year ago • 2 comments

Currently in zr_laser_bias_test, we are streaming individual laser-current leaves in sample mode. namely - instant/avg/min/max values.

During the verification process, since these are pulled at different times, the avg value is sometimes not between the min and max values causing false test failure.

"The average is not between the maximum and minimum values Avg:232.50 Min:232.60 Max:232.60"

To better suit the test intent, we need to change the test to stream at the container level i.e p1Stream := samplestream.New(t, dut1, component.OpticalChannel().LaserBiasCurrent().State(), 10*time.Second)

and then check the condition: min <= avg <= max for all the values "within" the container streamed at the same timestamp.

Test is passing with these changes.

karthikeya-remilla avatar Sep 26 '24 18:09 karthikeya-remilla

Pull Request Test Coverage Report for Build 11100370710

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 55.268%

Totals Coverage Status
Change from base Build 11097059185: 0.0%
Covered Lines: 1983
Relevant Lines: 3588

💛 - Coveralls

coveralls avatar Sep 26 '24 18:09 coveralls