featureprofiles icon indicating copy to clipboard operation
featureprofiles copied to clipboard

RT-1.27 : Fixing script issues seen after recent changes

Open trathod1 opened this issue 1 year ago • 2 comments

Following changes are made -

  1. Fixing the usage of deviations.SetMetricAsPreference, i.e. when this deviation is set true, script should configure the Preference with Metric value.
  2. Restoring the original static route as per these steps in readme, which make traffic validation possible - https://github.com/openconfig/featureprofiles/blob/66586143b8e4b24bf65b2db76e3f2dabfd5fdb48/feature/bgp/static_route_bgp_redistribution/otg_tests/static_route_bgp_redistribution_test/README.md?plain=1#L64 https://github.com/openconfig/featureprofiles/blob/66586143b8e4b24bf65b2db76e3f2dabfd5fdb48/feature/bgp/static_route_bgp_redistribution/otg_tests/static_route_bgp_redistribution_test/README.md?plain=1#L72
  3. Fixing validateLearnedIPv4Prefix and validateLearnedIPv6Prefix to validate rejected-route when shouldBePresent is set to false for some tests.

"This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."

trathod1 avatar Sep 20 '24 19:09 trathod1

Pull Request Functional Test Report for #3444 / fd146d57d05d853564661710a2eb39b78d08c393

Virtual Devices

Device Test Test Documentation Job Raw Log
Arista cEOS status
RT-1.27: Static route to BGP redistribution
de1d06a0 Log
Cisco 8000E status
RT-1.27: Static route to BGP redistribution
56d676bd Log
Cisco XRd status
RT-1.27: Static route to BGP redistribution
c6af4ac5 Log
Juniper ncPTX status
RT-1.27: Static route to BGP redistribution
d652251d Log
Nokia SR Linux status
RT-1.27: Static route to BGP redistribution
f5403500 Log
Openconfig Lemming status
RT-1.27: Static route to BGP redistribution
a75291fc Log

Hardware Devices

Device Test Test Documentation Raw Log
Arista 7808 status
RT-1.27: Static route to BGP redistribution
Cisco 8808 status
RT-1.27: Static route to BGP redistribution
Juniper PTX10008 status
RT-1.27: Static route to BGP redistribution
Nokia 7250 IXR-10e status
RT-1.27: Static route to BGP redistribution

Help

OpenConfigBot avatar Sep 20 '24 19:09 OpenConfigBot

Pull Request Test Coverage Report for Build 14621484863

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 18.016%

Totals Coverage Status
Change from base Build 14593131142: 0.0%
Covered Lines: 2481
Relevant Lines: 13771

💛 - Coveralls

coveralls avatar Sep 20 '24 19:09 coveralls

/fptest virtual

dplore avatar Nov 15 '24 23:11 dplore

This test is not passing on any virtual platforms. Please check the log at least for srlinux:

Log

dplore avatar Nov 19 '24 00:11 dplore

This test is not passing on any virtual platforms. Please check the log at least for srlinux:

Log

I am getting Forbidden Error 403 while accessing the logs. Can you please share the logs or enable the access to above url ?

trathod1 avatar Nov 19 '24 00:11 trathod1

/fptest virtual

trathod1 avatar Nov 20 '24 01:11 trathod1

/fptest virtual

dplore avatar Nov 21 '24 01:11 dplore

This test is not passing on any virtual platforms. Please check the log at least for srlinux: Log

I am getting Forbidden Error 403 while accessing the logs. Can you please share the logs or enable the access to above url ?

Apologies, looks like this log is only accessible to googlers over github.

dplore avatar Nov 21 '24 01:11 dplore

HW log with these changes are available at - b/380289416

trathod1 avatar Nov 22 '24 03:11 trathod1

Hi @trathod1 May I know the status of this PR?

ksgireesha avatar Mar 03 '25 14:03 ksgireesha

Hi @trathod1 May I know the status of this PR?

This PR is ready for review.

trathod1 avatar Mar 03 '25 16:03 trathod1

Hi @trathod1 May I know the status of this PR?

This PR is ready for review.

@nsadhasivam - Your attention is requested here

ksgireesha avatar Mar 03 '25 16:03 ksgireesha

@dplore , can you review this please

ksgireesha avatar Mar 17 '25 10:03 ksgireesha

/fptest virtual

nsadhasivam avatar Apr 29 '25 08:04 nsadhasivam