featureprofiles icon indicating copy to clipboard operation
featureprofiles copied to clipboard

RT 7.4 & RT 7.11: Updated the script with deviation for ASpath set

Open s-nandu opened this issue 1 year ago • 3 comments

RT 7.4 & RT 7.11: Updated the script with deviation for ASpath set

Added policy result as ACCEPT for policy "match_community_regex"

s-nandu avatar Aug 07 '24 00:08 s-nandu

Pull Request Test Coverage Report for Build 13814392929

Details

  • 7 of 24 (29.17%) changed or added relevant lines in 2 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.04%) to 18.213%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/deviations/deviations.go 0 3 0.0%
proto/metadata_go_proto/metadata.pb.go 7 21 33.33%
<!-- Total: 7 24
Files with Coverage Reduction New Missed Lines %
proto/metadata_go_proto/metadata.pb.go 3 5.48%
<!-- Total: 3
Totals Coverage Status
Change from base Build 13814371155: 0.04%
Covered Lines: 2477
Relevant Lines: 13600

💛 - Coveralls

coveralls avatar Aug 07 '24 00:08 coveralls

Fixes #3415

dplore avatar Sep 12 '24 18:09 dplore

@s-nandu please let us know if you will be resolving the comments.

dplore avatar Nov 12 '24 06:11 dplore

@s-nandu there are still conflicts to be resolved

dplore avatar Dec 03 '24 04:12 dplore

@s-nandu - Can you please resolve the conflicts?

ram-mac avatar Dec 17 '24 09:12 ram-mac

@juniper - Please resolve the conflicts in this PR so i can validate it. The conflicts are in the testcode itself.

ram-mac avatar Feb 10 '25 10:02 ram-mac

@ram-mac , resolved all the conflicts. Please merge the code after review @dplore , all comments have been resolved but the pull request still says there are unresolved comments. Please help rectify

s-nandu avatar Feb 12 '25 03:02 s-nandu

@s-nandu - i validated this change and looks like it is breaking one vendor during gnmi.Replace(ln502) is breaking with the following error "An unexpected element "match-as-path-set" is present".

ram-mac avatar Feb 12 '25 08:02 ram-mac

Please resolve the conflicts; So it can go for final approval and merge it soon.

ram-mac avatar Mar 12 '25 05:03 ram-mac