featureprofiles icon indicating copy to clipboard operation
featureprofiles copied to clipboard

Deviation removal from gNMI-1.10, gNOI-4.1, gNOI-2.1

Open hattikals opened this issue 1 year ago • 2 comments

Removing following deviations from scripts for Juniper, as these features are now supported on Juniper Devices

  • gNMI-1.10: telemetry_basic_check_test.go -> sw_version_unsupported
  • gNOI-4.1 : os_install_test.go -> sw_version_unsupported
  • gNOI-2.1: packet_link_qualification_test.go -> skip_plq_interface_oper_status_check

hattikals avatar Apr 25 '24 12:04 hattikals

Pull Request Test Coverage Report for Build 8833006508

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 55.448%

Totals Coverage Status
Change from base Build 8827157156: 0.0%
Covered Lines: 1949
Relevant Lines: 3515

💛 - Coveralls

coveralls avatar Apr 25 '24 13:04 coveralls

The code should also have been modified to remove obsolete if/else conditions, since sw_version_unsupported was used only by a single vendor. Additionally, as sw_version_unsupported is not used in other tests, it should've been removed from metadata.proto as well.

cc @dplore @cfernanz

LimeHat avatar Jun 28 '24 20:06 LimeHat