featureprofiles icon indicating copy to clipboard operation
featureprofiles copied to clipboard

[gNMI-1.11, RT-5.1/3] - add InterfaceCountersUpdateDelayed deviation for CISCO

Open kjahed opened this issue 1 year ago • 6 comments

CISCO interface counters telemetry does not reflect the latest value. This PR adds InterfaceCountersUpdateDelayed and modify gNMI-1.10, gNMI-1.11, RT-5.1, and RT-5.3 to wait until the counters are updated (for a max timeout) when activated.

In addition, for gNMI-1.10, modify verifyChassisIsAncestor to ignore ancestors with no type. This is similar to PR #2808 for gNMI-1.4.

kjahed avatar Mar 13 '24 23:03 kjahed

Pull Request Test Coverage Report for Build 11155885763

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 55.268%

Totals Coverage Status
Change from base Build 11155053907: 0.0%
Covered Lines: 1983
Relevant Lines: 3588

💛 - Coveralls

coveralls avatar Mar 14 '24 19:03 coveralls

@kjahed Please can you resolve the conflicts?

AmrNJ avatar Mar 25 '24 08:03 AmrNJ

LGTM, Please resolve the conflicts to merge

@AmrNJ done.

kjahed avatar Jun 12 '24 02:06 kjahed

@kjahed It still has conflicts and readme check fails. Please can you fix it?

AmrNJ avatar Jun 27 '24 16:06 AmrNJ

Merge conflicts are fixed, the Readme check fails due to some issue in test-requirements-template.md https://github.com/openconfig/featureprofiles/actions/runs/10944362833/job/30386029201?pr=2805

Local check passes for this test go run ./tools/validate_readme_spec/validate_readme_spec.go --feature-dir feature/interface/aggregate/otg_tests/balancing_test/README.md %

arvbaska1 avatar Sep 19 '24 16:09 arvbaska1