SAI icon indicating copy to clipboard operation
SAI copied to clipboard

Add support for VLAN Stacking/Translation API

Open kuanyu99 opened this issue 3 years ago • 7 comments

  • Define SAI layer VLAN translation and VLAN Stacking function API in saivlan.h

Use cases: https://github.com/Azure/SONiC/blob/f7920604b77525bd8a13432214fd8d4a5423933c/doc/vlan_stacking/vlan_stacking_HLD.md#vlan-stacking-deployment-use-cases

Examples: https://github.com/Azure/SONiC/blob/f7920604b77525bd8a13432214fd8d4a5423933c/doc/vlan_stacking/vlan_stacking_HLD.md#sai-api

kuanyu99 avatar Jan 20 '22 08:01 kuanyu99

Should we also extend saiacl.h to allow pop / swap ? We have SAI_ACL_ACTION_TYPE_ADD_VLAN_ID (push) and set outer/inner vlan ID (swap use case) But I don't see remove_vlan (pop)

itaibaz avatar Jan 21 '22 05:01 itaibaz

Need to have a SAI specific doc for this. And also describe how this fits to SAI behavioral model.

rlhui avatar Feb 24 '22 23:02 rlhui

Need to have a SAI specific doc for this. And also describe how this fits to SAI behavioral model.

I add a document about this new PR and also add a vlan stack stage into the pipeline. I have some problem editing the vsdx file. So I use a PDF to represent the pipeline model about the vlan stacking.

kuanyu99 avatar Mar 02 '22 02:03 kuanyu99

please fix errors:

WARNING: not expected number of spaces after * (1,4,8) saivlan.h 561:     *   outer vlan tag, the original one is an inner vlan tag.
WARNING: Long brief > 200 on SAI_VLAN_STACK_ATTR_MATCH_TYPE:
 - Match type The original Vlan ID should match to inner ta...

kcudnik avatar Mar 02 '22 15:03 kcudnik

Hi @rlhui @ashutosh-agrawal @itaibaz @kcudnik , Can we merge this PR? Or what should I do to proceed it?

kuanyu99 avatar Aug 10 '22 08:08 kuanyu99

please wait for others to apprive

kcudnik avatar Aug 11 '22 14:08 kcudnik

Hi @ashutosh-agrawal @srj102 @prvattem I have made some updates based on the comments recently. Please check if anything needs to be corrected or can we let the PR be merged.

kuanyu99 avatar Jul 10 '23 02:07 kuanyu99