OpenNetworkLinux icon indicating copy to clipboard operation
OpenNetworkLinux copied to clipboard

For platform AS7535-28XB-O-AC-F enhanced the sfpi.c with read/write API's to support ONLP_SFP_CONTROL for 'Soft Rate_Select Select' in Optional Status/Control Bits as per SFF-8472 Specification for Management Interface for SFP+

Open muthukumars-arrcus opened this issue 1 year ago • 1 comments

This PR is raised to add API's for Multirate soft select in sfp control get/set, for multirate supporting tranceivers

Note :ONL Code got approved and merged into the master (Ref : https://github.com/opencomputeproject/OpenNetworkLinux/pull/984)

Test System : Transeiver used for tesing FiniserFTLX8574D3BCV, it supports multimode rates (1G/10G). https://www.epsglobal.com/Media-Library/EPSGlobal/Products/files/finisar/transceivers/FTLX8574D3BCV.pdf?ext=.pdf Platform : AS7535-28XB-O-AC-F Transeiver used : The port with the above transeiver is connected to IXIA port with same transeriver Port UP & DOWN state changes are verfied Validated the updation of register at locations 0x50 and 0x51 using i2cget command also

Requesting for review and comment/approve the code change

muthukumars-arrcus avatar Jul 01 '24 08:07 muthukumars-arrcus

Hi @Edgecore team, Please provide confirmation in the PR and notify the ONL manager to merge it.

muthukumars-arrcus avatar Jul 01 '24 08:07 muthukumars-arrcus

@sonoble , "brandonchuang" from edge core has approved. Can you please merge the PR

Regards S Muthu Kumar

muthukumars-arrcus avatar Jul 11 '24 04:07 muthukumars-arrcus

Thank you for your patch. Please improve the git commit message and the merge/pull request description (summary/title).

paulmenzel avatar Jul 11 '24 04:07 paulmenzel

Thank you for your patch. Please improve the git commit message and the merge/pull request description (summary/title).

Addressed the above comment. Please merge.

muthukumars-arrcus avatar Jul 11 '24 05:07 muthukumars-arrcus

@sonoble / @paulmenzel , " @brandonchuang from edge core has already approved . Also all comments addressed.

Can you please merge the PR

muthukumars-arrcus avatar Jul 16 '24 03:07 muthukumars-arrcus

@sonoble / @paulmenzel , A Gentle reminder

muthukumars-arrcus avatar Jul 18 '24 22:07 muthukumars-arrcus

@paulmenzel / @sonoble , @brandonchuang from edge core has already approved . Also all comments addressed.

Can you please merge the PR.

I am tracking this for quite some time

muthukumars-arrcus avatar Jul 22 '24 06:07 muthukumars-arrcus

@sonoble / @paulmenzel , A Gentle reminder again

muthukumars-arrcus avatar Jul 30 '24 04:07 muthukumars-arrcus

Hi @sonoble / @paulmenzel ,

@brandonchuang from edge core has already approved . Also all comments addressed.

Can you please merge the PR.

muthukumars-arrcus avatar Aug 08 '24 05:08 muthukumars-arrcus