OpenNetworkLinux icon indicating copy to clipboard operation
OpenNetworkLinux copied to clipboard

Specify onie img file

Open ingridcelestica opened this issue 1 year ago • 5 comments

ONIE with secureboot will have <initrd.img-5.4.86-onie.sig> and <initrd.img-5.4.86-onie>. The community code doesn't specify to use the <initrd.img-5.4.86-onie> which will impact the ONL installation. Could we modify the pat to <onie/initrd.img*-onie> make it specifically to use the one without sig? def _g(d): pat = os.path.join(d, "onie/initrd.img*") l = glob.glob(pat) if l: return l[0] return None From <packages/base/all/vendor-config-onl/src/python/onl/install/ShellApp.py> line 109.

ingridcelestica avatar Oct 10 '23 03:10 ingridcelestica

@sonoble Could you please help check this issue?Thank you.

ingridcelestica avatar Oct 11 '23 08:10 ingridcelestica

Hello, this appears to be secure grub in ONIE : https://github.com/opencomputeproject/onie/blob/master/build-config/make/grub.make I see the issue as we would not pick up the actual initrd, but just a signature file. I will go ahead and see if we do this anywhere else as the kernel is signed also:

` /mnt/onie-boot/onie/initrd.img-5.4.86-onie.sig,

/mnt/onie-boot/onie/vmlinuz-5.4.86-onie.sig,

/mnt/onie-boot/grub/grub_sb.cfg.sig`

sonoble avatar Oct 11 '23 17:10 sonoble

Hello, this appears to be secure grub in ONIE : https://github.com/opencomputeproject/onie/blob/master/build-config/make/grub.make I see the issue as we would not pick up the actual initrd, but just a signature file. I will go ahead and see if we do this anywhere else as the kernel is signed also:

` /mnt/onie-boot/onie/initrd.img-5.4.86-onie.sig,

/mnt/onie-boot/onie/vmlinuz-5.4.86-onie.sig,

/mnt/onie-boot/grub/grub_sb.cfg.sig`

Hello. What do you think the way if we add "-onie" to make it specifically point to the file without .sig?

ingridcelestica avatar Oct 12 '23 01:10 ingridcelestica

@sonoble Kindly ask is there any update? What's you opinion about the solution I commented above? Thank you.

ingridcelestica avatar Oct 16 '23 02:10 ingridcelestica

@sonoble Hi Steven. Any update from you?

ingridcelestica avatar Oct 23 '23 01:10 ingridcelestica