OpenNetworkLinux icon indicating copy to clipboard operation
OpenNetworkLinux copied to clipboard

Published 20 hours ago • verified publisher icon opencomputeproject

[Edgecore][as7926_40xfb] Update drivers/API to match latest BMC firmware

Open brandonchuang opened this issue 2 years ago • 2 comments

  • Remove i2c mux 0x72 which is used by BMC
  • Use GNU indent to format peripheral drivers
  • Add BMC detection in init.py
  • Add ONLP_SFP_CONTROL_RESET in sfp.py

Signed-off-by: Brandon Chuang [email protected]

brandonchuang avatar Jul 18 '22 08:07 brandonchuang

Thank you for the patch.

  1. Could you please split the reformatting with GNU indent in a separate commit, so it’s easier to review the actual changes?
  2. Please describe, since what BMC firmware version these changes are needed, what the changes in the firmware are, and if it’s backwards compatible.

paulmenzel avatar Jul 18 '22 09:07 paulmenzel

Thank you for the patch.

  1. Could you please split the reformatting with GNU indent in a separate commit, so it’s easier to review the actual changes?
  2. Please describe, since what BMC firmware version these changes are needed, what the changes in the firmware are, and if it’s backwards compatible.

Split the reformatting with GNU indent in a separate commit. Update BMC version and description in commit message.

brandonchuang avatar Jul 19 '22 03:07 brandonchuang