OpenNetworkLinux
OpenNetworkLinux copied to clipboard
opencomputeproject
[S9500-22XST] Add Ufispace S9500-22XST platform support
Add Ufispace S9500-22XST platform (CSGR - Cell Site Gateway Router)
Platform S9500-22XST CPU: Intel Broadwell-DE MAC: Broadcom BCM88470 Network: 4 x 1GE RJ45 ethernet ports + 8 x 10GbE SFP+ ethernet ports + 8 x 25GbE SFP28 ethernet ports + 2 x 100GbE QSFP28 ethernet ports External interfaces: USB 2.0, SMA 1PPS, SMA 10MHz, GNSS, 1GbE RJ45 management port
Hi, I have already merged S9500-22XST code with latest master branch. Could you help review it ? thanks.
(I saw the GitHub merge/pull request description. Please also put that into the commit message, and extend the other information.)
Hi, How about the modified commit messages ? And our some software customers use 4.19 but some use 5.4. Our default is for 4.19. So we would need to support these two kernels on this platform.
Thank you for the quick follow-up. Please rebase the commit on the ONL master branch, and force push.
Good to know regarding the Linux kernel version, please mention that in the commit message.
How about the current modified commit ? Any other suggestion, please let me know, thanks.
Thank you. Please squash both commits and force push. But, I think you can do the Linux kernel configuration changes in the same merge/pull requests. But please as separate commits with an explanation for each Linux kernel configuration change, as it affects all devices, so we need to know, why the size increases for example. (No idea, if the ONL build system allows other ways to add platform specific Linux kernel configurations.)
Sorry, I overlooked MAC: Broadcom BCM88470. Excuse my ignorance, what does MAC mean?
Please extend the commit message, saying:
- what other (maybe proprietary) components are needed to make the switching ASIC work, and
- how you tested it (ONIE version, and version of other possibly external components).
Hello,
Can you also fix the DCO issue:
https://github.com/opencomputeproject/OpenNetworkLinux/pull/881/checks?check_run_id=5965266274
I have re-commited the changes. In the industry, I usually call "NIC" or switch chip as MAC. I have changed this name as switch chip in commit.
I still didn’t find the documentation, where to get the blobs to get the Broadcom switching ASIC to work.
Sorry, I did not get your points. Broadcom ASIC would need Broadcom SDK to do initialization. But Broadcom SDK needs license, so we can't put this on ONL. The ONL user would needs to request Broadcom SDK for Broadcom switch chip. Does this answer your question ?
Broadcom ASIC would need Broadcom SDK to do initialization. But Broadcom SDK needs license, so we can't put this on ONL.
Yes, I am aware of this. I am only talking about documentation.
The ONL user would needs to request Broadcom SDK for Broadcom switch chip. Does this answer your question?
Yes, I would like to have such a comment in the commit message. Also, please document, the Broadcom SDK version you tested with.
Unrelated from this merge/pull request, is there (ONL) documentation, what to do, when you have the Broadcom SDK for users starting with ONL?
Broadcom ASIC would need Broadcom SDK to do initialization. But Broadcom SDK needs license, so we can't put this on ONL.
Yes, I am aware of this. I am only talking about documentation.
The ONL user would needs to request Broadcom SDK for Broadcom switch chip. Does this answer your question?
Yes, I would like to have such a comment in the commit message. Also, please document, the Broadcom SDK version you tested with.
Unrelated from this merge/pull request, is there (ONL) documentation, what to do, when you have the Broadcom SDK for users starting with ONL?
OK, got it. I will add such kind of comment in commit message. We have detailed Broadcom SDK integration guide to help ONL customer to integrate Broadcom SDK and related PHY driver. Also we will provide basic SDK config for serdes setting to activate all switch ports.
Awesome. Thank you.
PS: Unrelated, I am just curious, as you use Intel Broadwell based system, are you using a coreboot based firmware?
Awesome. Thank you.
PS: Unrelated, I am just curious, as you use Intel Broadwell based system, are you using a coreboot based firmware?
No, as I mentioned in commit message, we use AMI BIOS.
I have updated related commit, please have a review, thanks. Any question, please let me know.
After internal discussion and retest:
- kernel 4.19 already has our needed driver, CONFIG_USB_ACM, and we don't need CONFIG_USB_GADGET and related config.
- kernel 5.4 would need more test to modify our needed configs to "module". We would like to add this platform first to ONL official support for only kernel 4.19. Thanks.