lean-mlir icon indicating copy to clipboard operation
lean-mlir copied to clipboard

Handshake-DC: add support for Int in Streams

Open luisacicolini opened this issue 1 year ago • 10 comments

This PR enables defining streams of int and bool for the formalization of DC and Handshake dialects from CIRCT

luisacicolini avatar Aug 09 '24 14:08 luisacicolini

Alive Statistics: 64 / 93 (29 failed)

github-actions[bot] avatar Aug 09 '24 15:08 github-actions[bot]

Nice. I am happy to see this being merged if you feel this is sensible.

tobiasgrosser avatar Aug 09 '24 18:08 tobiasgrosser

Yes! Syncing with main broke the example but as soon as that's fixed I'm happy to merge

luisacicolini avatar Aug 10 '24 06:08 luisacicolini

Alive Statistics: 64 / 93 (29 failed)

github-actions[bot] avatar Aug 12 '24 07:08 github-actions[bot]

Nice. 👍

tobiasgrosser avatar Aug 12 '24 08:08 tobiasgrosser

Alive Statistics: 64 / 93 (29 failed)

github-actions[bot] avatar Aug 12 '24 20:08 github-actions[bot]

now ready for review (except for broken test), CC: @ymherklotz :)

luisacicolini avatar Aug 12 '24 20:08 luisacicolini

Overall LGTM. I didn't take too close a look, but I trust you, and it seems like we're trying to figure out the precise modelling, so bikeshedding isn't worth it!

bollu avatar Aug 13 '24 15:08 bollu

thank you @bollu for the review! Indeed this model is not definitive and potentially subject to changes as we refine it

luisacicolini avatar Aug 13 '24 20:08 luisacicolini

Alive Statistics: 64 / 93 (29 failed)

github-actions[bot] avatar Aug 13 '24 20:08 github-actions[bot]

Can we now press the merge button. I am afraid the upcoming lean updates will risk this code to become outdated again. As soon as its merged, I can look into why the example breaks.

tobiasgrosser avatar Aug 16 '24 06:08 tobiasgrosser

perfect, merging now!

luisacicolini avatar Aug 16 '24 07:08 luisacicolini

Nice. Thank you for the quick response.

tobiasgrosser avatar Aug 16 '24 07:08 tobiasgrosser