opencollective-frontend
opencollective-frontend copied to clipboard
Changed the Twitter logo
Resolve https://github.com/opencollective/opencollective/issues/7195
Description
New Twitter (X) logo is added in the footer and header of open collective page
Screenshots
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
opencollective-frontend | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Jan 30, 2024 1:18pm |
opencollective-styleguide | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Jan 30, 2024 1:18pm |
I haven't tried locally, but this crashes the homepage on Vercel: https://opencollective-frontend-git-fork-mayasati-72655d-opencollective.vercel.app.
[Error: EMFILE: too many open files, open '/var/task/node_modules/@icons-pack/react-simple-icons/icons/SiGooglemaps.mjs'] {
errno: -24,
code: 'EMFILE',
syscall: 'open',
path: '/var/task/node_modules/@icons-pack/react-simple-icons/icons/SiGooglemaps.mjs',
page: '/home'
}
Error: Runtime exited with error: exit status 1
Runtime.ExitError
@Betree I found this https://github.com/phosphor-icons/react/issues/45#issuecomment-1760724607 and tried to make the changes accordingly. It was working fine locally but can you check if this resolves the error
@Betree I found this phosphor-icons/react#45 (comment) and tried to make the changes accordingly. It was working fine locally but can you check if this resolves the error
Still getting the same issue
@betree what should I do to remove this error? Should I use a different library instead of react-simple-icons?
@betree what should I do to remove this error?
I have no clue on how to resolve this, and the resolution of this issue is not a priority so I can't invest time in researching solutions.
If you don't have the time to research it yourself, I suggest closing the PR and moving on to something more straightforward.
@Betree can I use react-icons https://www.npmjs.com/package/react-icons instead of react-simple-icons?
I don't have the bandwidth to research and decide on an icon library. I suggest closing the PR if we can't make it work with the initial specs.
@Betree I will look again for a solution. Please do not close this issue till then.
@Betree Can you check it now?
@Betree Do I need to perform rebase to solve conflict?
If you're not comfortable with it, I can take care of that part
Can you please do the rebase part? I'm not sure on how to do this
I updated react-simple-icons package to latest version and checked. It is working fine locally. But in the editor I am getting the error.