opencollective-frontend icon indicating copy to clipboard operation
opencollective-frontend copied to clipboard

Changed the Twitter logo

Open MayaSatishRao opened this issue 1 year ago • 14 comments

Resolve https://github.com/opencollective/opencollective/issues/7195

Description

New Twitter (X) logo is added in the footer and header of open collective page

Screenshots

Screenshot 2024-01-08 200030 Screenshot 2024-01-08 200109

MayaSatishRao avatar Jan 08 '24 14:01 MayaSatishRao

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
opencollective-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 30, 2024 1:18pm
opencollective-styleguide ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 30, 2024 1:18pm

vercel[bot] avatar Jan 08 '24 14:01 vercel[bot]

I haven't tried locally, but this crashes the homepage on Vercel: https://opencollective-frontend-git-fork-mayasati-72655d-opencollective.vercel.app.

[Error: EMFILE: too many open files, open '/var/task/node_modules/@icons-pack/react-simple-icons/icons/SiGooglemaps.mjs'] {
  errno: -24,
  code: 'EMFILE',
  syscall: 'open',
  path: '/var/task/node_modules/@icons-pack/react-simple-icons/icons/SiGooglemaps.mjs',
  page: '/home'
}
Error: Runtime exited with error: exit status 1
Runtime.ExitError

Betree avatar Jan 09 '24 15:01 Betree

@Betree I found this https://github.com/phosphor-icons/react/issues/45#issuecomment-1760724607 and tried to make the changes accordingly. It was working fine locally but can you check if this resolves the error

MayaSatishRao avatar Jan 09 '24 15:01 MayaSatishRao

@Betree I found this phosphor-icons/react#45 (comment) and tried to make the changes accordingly. It was working fine locally but can you check if this resolves the error

Still getting the same issue

image

Betree avatar Jan 17 '24 08:01 Betree

@betree what should I do to remove this error? Should I use a different library instead of react-simple-icons?

MayaSatishRao avatar Jan 17 '24 08:01 MayaSatishRao

@betree what should I do to remove this error?

I have no clue on how to resolve this, and the resolution of this issue is not a priority so I can't invest time in researching solutions.

If you don't have the time to research it yourself, I suggest closing the PR and moving on to something more straightforward.

Betree avatar Jan 17 '24 11:01 Betree

@Betree can I use react-icons https://www.npmjs.com/package/react-icons instead of react-simple-icons?

MayaSatishRao avatar Jan 17 '24 11:01 MayaSatishRao

I don't have the bandwidth to research and decide on an icon library. I suggest closing the PR if we can't make it work with the initial specs.

Betree avatar Jan 29 '24 15:01 Betree

@Betree I will look again for a solution. Please do not close this issue till then.

MayaSatishRao avatar Jan 29 '24 16:01 MayaSatishRao

@Betree Can you check it now?

MayaSatishRao avatar Jan 29 '24 19:01 MayaSatishRao

@Betree Do I need to perform rebase to solve conflict?

MayaSatishRao avatar Jan 30 '24 12:01 MayaSatishRao

If you're not comfortable with it, I can take care of that part

Betree avatar Jan 30 '24 12:01 Betree

Can you please do the rebase part? I'm not sure on how to do this

MayaSatishRao avatar Jan 30 '24 12:01 MayaSatishRao

I updated react-simple-icons package to latest version and checked. It is working fine locally. But in the editor I am getting the error. Screenshot 2024-01-30 190903

MayaSatishRao avatar Jan 30 '24 13:01 MayaSatishRao