opencollective-frontend
opencollective-frontend copied to clipboard
opencollective
feat: Add host fee to default transaction filters (#5549)
Resolve https://github.com/opencollective/opencollective/issues/5549
Description
Adds "Host Fee" to the default transaction filters for the frontend. Based on this comment it sounds like there is a backend change needed as well.
Screenshots
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Updated |
|---|---|---|---|
| opencollective-frontend | ✅ Ready (Inspect) | Visit Preview | Jul 7, 2022 at 8:17PM (UTC) |
| opencollective-styleguide | ✅ Ready (Inspect) | Visit Preview | Jul 7, 2022 at 8:17PM (UTC) |
![vercel[bot] avatar](https://avatars.githubusercontent.com/in/8329?v=4 "Published by a pub.dev verified publisher"){kind=small}
@ktasdf is attempting to deploy a commit to the Open Collective Team on Vercel.
A member of the Team first needs to authorize it.
Thank you, the PR is looking good and is doing what was asked in the issue.
However, not merging it for now because I'm not 100% sure we want to do this at this point. For Collectives, half of the transactions are gonna be Host Fees and that will look a bit odd. Need to get some temperature check from other team members.
Thanks for the feedback! I've closed the accompanying API PR for now (https://github.com/opencollective/opencollective-api/pull/7697) but can circle back if y'all want to merge this in the future. Feel free to close this one as well if y'all don't want to make this change.