arpack-ng icon indicating copy to clipboard operation
arpack-ng copied to clipboard

Non constant array size in icb_arpack_c.c

Open dariomangoni opened this issue 4 years ago • 1 comments

Actual behavior

All the constant-size stack arrays defined in icb_arpack_c.c have a size defined by an a_int variable that does not have the required constness. e.g.

a_int N = 1000;
double resid[N];

thus giving the error: Expression must have a constant value

It would probably be better to use malloc or either use #define.

Where/how to reproduce the problem

  • arpack-ng: 0a655d918d558ef97881db2760668b8d1e3b4bc1
  • OS: Win10
  • compiler: MSVC

Steps to reproduce the problem

  • run icb_arpack_c.c

dariomangoni avatar Jun 16 '21 13:06 dariomangoni

@fghoussen this seems to be fixed by my recent clean.

wztzjhn avatar Aug 15 '22 17:08 wztzjhn

Fixed by #371

fghoussen avatar Aug 20 '22 19:08 fghoussen