relex icon indicating copy to clipboard operation
relex copied to clipboard

"as" comparatives broken in unit test

Open linas opened this issue 11 years ago • 4 comments

See bug #155 and the comments there for

The kick was as soft as the first. He is as smart as I ever expected him to be

which should probably be:

as(taste, do) as(run, do) as(soft, first) as(smart, be)

linas avatar Aug 28 '14 03:08 linas

@linas As I commented on #149, I was thinking to represent the "as" comparatives the similar way as "than" comparatives, i.e. using "as" to connect the two comparison entities, the same way as "than" from the than-comparatives sentences. So according to the current representations, the sentence

The kick was softer than the first.

will be represented as:

_comparative(soft, kick)
than(kick, first)
degree(soft, comparative)

right?

so, for the sentence "The kick was as soft as the first." can be represented:

_comparative(soft, kick)
as(kick, first)

Does it make sense to you?

ruiting avatar Aug 29 '14 03:08 ruiting

Oh, yes, right, makes perfect sense. The _predadj(kick, soft) confused me. Do you want _comparative(soft, kick) in addition to the predadj, or instead of it?

linas avatar Aug 29 '14 22:08 linas

anyway, the stuff that is currently in the unit test for these comparatives is wrong and/or unreviewd. And relex is probably broken for these, anyway ...

linas avatar Aug 29 '14 22:08 linas

I think we need both _predadj(kick, soft) and _comparative(soft, kick), as they will generate different logic representation for different meanings...

ruiting avatar Sep 01 '14 03:09 ruiting