atomspace icon indicating copy to clipboard operation
atomspace copied to clipboard

ptv, stv, ftv values are not checking for strength to be between [0, 1]

Open amebel opened this issue 10 years ago • 2 comments

guile> (define foo (stv 748357403 1))

guile> (cog-tv->alist foo)
((count . 4473923584.0) (mean . 748357376.0) (confidence . 0.9999998211860657))
guile> (define bar (stv 748357403 17584760854376))

guile> (cog-tv->alist bar)
((count . 4473923584.0) (mean . 748357376.0) (confidence . 0.9999998211860657))

This might be the wanted feature of stv as it is being used differently by different codebases. But, ptv and ftv shouldn't, and if I am not mistaken ptv should have confidence2count method similar to https://github.com/opencog/atomspace/blob/master/opencog/atomspace/FuzzyTruthValue.cc#L122 maybe with a different formula

amebel avatar May 25 '15 05:05 amebel

the language learning code currently uses the CountTV, and it stores negative numbers in the confidence field (logarithm of small probabilities, etc.) Yes, this should be redone someday, somehow, I guess.

linas avatar May 28 '15 03:05 linas

Hmm, OK, well if you really want CountTV to be like this, then we will need to come up with another name for the simplistic CountTV that we want (without any logarithms involved, etc.).... Maybe SimpleCountTV?

ben

On Thu, May 28, 2015 at 11:43 AM, Linas Vepštas [email protected] wrote:

the language learning code currently uses the CountTV, and it stores negative numbers in the confidence field (logarithm of small probabilities, etc.) Yes, this should be redone someday, somehow, I guess.

— Reply to this email directly or view it on GitHub https://github.com/opencog/atomspace/issues/59#issuecomment-106161967.

Ben Goertzel, PhD http://goertzel.org

"The reasonable man adapts himself to the world: the unreasonable one persists in trying to adapt the world to himself. Therefore all progress depends on the unreasonable man." -- George Bernard Shaw

bgoertzel avatar May 28 '15 05:05 bgoertzel