go-tunnel icon indicating copy to clipboard operation
go-tunnel copied to clipboard

Crypto Go :we are a research group to help developers build secure applications.

Open 1047261438 opened this issue 1 year ago • 1 comments

Hi, we are a research group to help developers build secure applications. We designed a cryptographic misuse detector (i.e., CryptoGo) on Go language. We found your great public repository from Github, and several security issues detected by CryptoGo are shown in the following. Note that the cryptographic algorithms are categorized with two aspects: security strength and security vulnerability based on NIST Special Publication 800-57 and other public publications. Moreover, CryptoGo defined certain rules derived from the APIs of Go cryptographic library and other popular cryptographic misuse detectors. The specific security issues we found are as follows: Location: src/conf.go:335; Broken rule: SSL/TLS use insecure verification; We wish the above security issues could truly help you to build a secure application. If you have any concern or suggestion, please feel free to contact us, we are looking forward to your reply. Thanks.

1047261438 avatar Aug 29 '22 05:08 1047261438

Thanks for doing the review. The code does not skip TLS verification - if you see the line where InsecureSkipVerify is set to true, it is ONLY done if the peer is not referred by name. Additionally, a large warning is printed to the logs.

opencoff avatar Aug 29 '22 20:08 opencoff