Opencode-Collaborative-20 icon indicating copy to clipboard operation
Opencode-Collaborative-20 copied to clipboard

Added navdrawer

Open shuba400 opened this issue 5 years ago • 19 comments

171

Fixes #171

Short description of what this resolves:

Added navbar drawer and resolved the conflict from the previous case

Changes proposed in this pull request and/or Screenshots of changes:

shuba400 avatar Jan 20 '20 06:01 shuba400

Sir I closed the previous PR as I was not able to resolve conflict an made this new one which can be easily merged Here is a live link now https://shuba400.github.io/Opencode-Collaborative-20/

shuba400 avatar Jan 20 '20 06:01 shuba400

Sir I have resolved the conflicts. Please tell if any other thing is neede to change and I will do it asap

shuba400 avatar Jan 21 '20 07:01 shuba400

Check the mobile view, fix it.

thesmallstar avatar Jan 21 '20 11:01 thesmallstar

Update- Sir I have fixed the mobile view

shuba400 avatar Jan 21 '20 12:01 shuba400

Sir I have made changes in the mobile vies of the site and also added the required buttons on the navdrawer. If any other things are needed I will do it asap

shuba400 avatar Jan 22 '20 15:01 shuba400

Sir please merge this PR

shuba400 avatar Jan 23 '20 17:01 shuba400

@shuba400 Great work! Please squash the commits and the PR will be ready to merge.

zerefwayne avatar Jan 23 '20 21:01 zerefwayne

Sir I am not able to understand squash from net. Can you please share a link on squashing commits.

shuba400 avatar Jan 25 '20 10:01 shuba400

Sir I am not able to understand squash from net. Can you please share a link on squashing commits.

https://github.com/wprig/wprig/wiki/How-to-squash-commits and also resolve conflicts.

NitinMadhukar avatar Jan 25 '20 11:01 NitinMadhukar

Sir I had conflict in the previous case, so what I did was that I closed that PR, deleted the repo and forked the new repo which was up to date and made the necessary changes and made a new PR. It was ready to merge. But now it is again showing conflicts. So is there a efficient way of doing this task

shuba400 avatar Jan 25 '20 11:01 shuba400

Conflict has been fixed But squashing is giving some problem There are no commits showing in my machine for squashing where I need to change pick to squash 2020-01-26 (1) @NitinMadhukar

shuba400 avatar Jan 26 '20 10:01 shuba400

@shuba400 resolve conflicts.

NitinMadhukar avatar Jan 29 '20 18:01 NitinMadhukar

Update - Conflict Resolved

shuba400 avatar Jan 30 '20 10:01 shuba400

@shuba400 squash commits

NitinMadhukar avatar Jan 30 '20 10:01 NitinMadhukar

@shuba400 Resolve conflicts

Jigar3 avatar Feb 12 '20 14:02 Jigar3

Update - Conflict Resolved

shuba400 avatar Feb 12 '20 14:02 shuba400

live-link?

Jigar3 avatar Feb 12 '20 15:02 Jigar3

Remove the facebook and twitter links from navbar

Jigar3 avatar Feb 12 '20 15:02 Jigar3

@shuba400 resolve conflicts

NitinMadhukar avatar Feb 13 '20 10:02 NitinMadhukar