memote icon indicating copy to clipboard operation
memote copied to clipboard

Update RegEx patterns for annotation IDs

Open WalkerKnapp opened this issue 1 year ago • 1 comments

  • [x] Does not fix an open issue

This fix is related to issue #315, but it is a band-aid solution for the current state of database IDs, not an automatic solution as suggested in the issue.

  • [x] description of feature/fix

The Regex patterns which are used to match against annotation IDs in test_*_annotation_wrong_ids tests have gone out of date since they were last updated. This PR replaces out-of-date ID patterns with the latest versions retrieved from https://registry.identifiers.org/registry.

I first noticed this problem when evaluating a model which uses a refseq id in the format WP_*, which is now a valid ID. While updating this pattern, I noticed that others have gone out of date as well and have updated them too.

  • [x] tests added/passed

All previous tests in tests/test_for_support/test_for_annotation.py still apply and pass, and no additional functionality which would require tests has been introduced.

  • [x] add an entry to the next release

WalkerKnapp avatar Sep 22 '23 03:09 WalkerKnapp

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (12338a6) 74.85% compared to head (8358d2a) 74.85%.

:exclamation: Current head 8358d2a differs from pull request most recent head 0666f99. Consider uploading reports for the commit 0666f99 to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #751   +/-   ##
========================================
  Coverage    74.85%   74.85%           
========================================
  Files           50       50           
  Lines         2955     2955           
  Branches       669      669           
========================================
  Hits          2212     2212           
  Misses         649      649           
  Partials        94       94           
Files Coverage Δ
src/memote/support/annotation.py 100.00% <ø> (ø)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Sep 22 '23 08:09 codecov[bot]