cobratoolbox icon indicating copy to clipboard operation
cobratoolbox copied to clipboard

Why is rxn.mat loaded in neighborRxn2data

Open akaviaLab opened this issue 5 years ago • 2 comments

https://github.com/opencobra/cobratoolbox/blob/c72a7bd511f79ebc1b6b1e0421544b22b4a9335d/src/reconstruction/rBioNet/neighborRxn2data.m#L44

This is unclear, since it loads up existing data, instead of using the model. Was this perhaps meant to be "rxns"?

akaviaLab avatar May 13 '19 15:05 akaviaLab

rxn.mat is a small matrix distributed in src/reconstruction/rBioNet/rxn.mat and in cobratoolbox/test/verifiedTests/reconstruction/testRBioNet/ which seems to bias the functions of rBioNet. ping @laurentheirendt, @rmtfleming, since I believe you guys wrote rBioNet.

akaviaLab avatar Jun 10 '19 13:06 akaviaLab

Hi, I think rxn.mat is a set of reactions. It is assumed that it is in the current folder or a folder in the current path. Perhaps the code could be edited to select a path to a rxn.mat. Regards, Ronan

https://github.com/opencobra/cobratoolbox/blob/c72a7bd511f79ebc1b6b1e0421544b22b4a9335d/src/reconstruction/rBioNet/rxn.mat

On Mon, 10 Jun 2019 at 14:28, akaviaLab [email protected] wrote:

rxn.mat is a small matrix distributed in src/reconstruction/rBioNet/rxn.mat and in cobratoolbox/test/verifiedTests/reconstruction/testRBioNet/ which seems to bias the functions of rBioNet. ping @laurentheirendt https://github.com/laurentheirendt, @rmtfleming https://github.com/rmtfleming, since I believe you guys wrote rBioNet.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/opencobra/cobratoolbox/issues/1473?email_source=notifications&email_token=AAQMEOQPWB4JGIVOMHC7AALPZZJJJA5CNFSM4HMRARTKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXJ4CEA#issuecomment-500416784, or mute the thread https://github.com/notifications/unsubscribe-auth/AAQMEOSL3QWSUHYCWSEHXM3PZZJJJANCNFSM4HMRARTA .

--

Mr. Ronan MT Fleming B.V.M.S. Dip. Math. Ph.D.

Assistant Professor, Division of Systems Biomedicine and Pharmacology, Leiden Academic Centre for Drug Research, Faculty of Science, Leiden University. https://www.universiteitleiden.nl/en/staffmembers/ronan-fleming & H2020 Project Coordinator Systems Medicine of Mitochondrial Parkinson’s Disease http://sysmedpd.eu

Peer-reviewed publications: https://goo.gl/FZPG23 Mobile: +353 873 413 072 Skype: ronan.fleming

(This message is confidential and may contain privileged information. It is intended for the named recipient only. If you receive it in error please notify me and permanently delete the original message and any copies.)

rmtfleming avatar Jun 12 '19 15:06 rmtfleming