cobrapy icon indicating copy to clipboard operation
cobrapy copied to clipboard

Consistent list annotation

Open Hemant27031999 opened this issue 4 years ago • 2 comments

This PR is solving issue #736 and #706. A new function _fix_annotation() has been added which fixes the incorrect annotation format.

Hemant27031999 avatar Jun 04 '20 19:06 Hemant27031999

Codecov Report

Merging #959 into devel will decrease coverage by 0.17%. The diff coverage is 86.20%.

Impacted file tree graph

@@            Coverage Diff             @@
##            devel     #959      +/-   ##
==========================================
- Coverage   84.63%   84.45%   -0.18%     
==========================================
  Files          50       50              
  Lines        4438     4459      +21     
  Branches      998     1006       +8     
==========================================
+ Hits         3756     3766      +10     
- Misses        441      449       +8     
- Partials      241      244       +3     
Impacted Files Coverage Δ
cobra/io/dict.py 87.50% <83.33%> (-0.97%) :arrow_down:
cobra/io/sbml.py 79.97% <100.00%> (-0.08%) :arrow_down:
cobra/core/object.py 94.28% <0.00%> (-5.72%) :arrow_down:
cobra/sampling/hr_sampler.py 83.42% <0.00%> (-2.68%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d362f51...351d5c3. Read the comment docs.

codecov-commenter avatar Jun 04 '20 19:06 codecov-commenter

Hey @Hemant27031999, this is good work but unfortunately, I don't think we can merge it without a change to the JSON schema. As you can read in #967, I would love to refactor this functionality into a separate package. And even if we don't do that, I think the JSON schema should be generated from pydantic models rather than crafted by hand. So I'm afraid, I can't merge this PR at this point as it is blocked.

Midnighter avatar Jul 16 '20 21:07 Midnighter